-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Reorganize PortfolioBalance
#11520
chore: Reorganize PortfolioBalance
#11520
Conversation
…/metamask-mobile into chore/componetize-tokens-screen
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Bitrise❌❌❌ Commit hash: c570c2c Note
Tip
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## chore/componetize-tokens-screen #11520 +/- ##
==================================================================
Coverage ? 53.87%
==================================================================
Files ? 1648
Lines ? 38241
Branches ? 4639
==================================================================
Hits ? 20601
Misses ? 16227
Partials ? 1413
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
a5d8b71
Bitrise✅✅✅ Commit hash: 96436be Note
|
…-reorg-portfolio-balance
Bitrise✅✅✅ Commit hash: da5862d Note
|
…-reorg-portfolio-balance
Quality Gate passedIssues Measures |
Description
Step 2 of token sorting is to move
PortfolioBalance
above theTabView
. This PR introduces this UI change to move thePortfolioBalance
above theTabView
, since it can happen separately from the Token sorting task in order to keep PRs small and easy to review / get past CI.No functional changes. I did bump the font variant per the design spec to
TextVariant.DisplayMD
Related issues
Design: https://www.figma.com/design/aMYisczaJyEsYl1TYdcPUL/Portfolio-View?node-id=5008-57060&node-type=frame&t=DkOQgh3ZMZfzy6C4-0
Manual testing steps
Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist