Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Reorganize PortfolioBalance #11520

Conversation

gambinish
Copy link
Contributor

@gambinish gambinish commented Oct 1, 2024

Description

Step 2 of token sorting is to move PortfolioBalance above the TabView. This PR introduces this UI change to move the PortfolioBalance above the TabView, since it can happen separately from the Token sorting task in order to keep PRs small and easy to review / get past CI.

No functional changes. I did bump the font variant per the design spec to TextVariant.DisplayMD

Related issues

Design: https://www.figma.com/design/aMYisczaJyEsYl1TYdcPUL/Portfolio-View?node-id=5008-57060&node-type=frame&t=DkOQgh3ZMZfzy6C4-0

Manual testing steps

Screenshots/Recordings

Screenshot 2024-09-30 at 10 29 54 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

gambinish and others added 23 commits September 26, 2024 17:09
…/metamask-mobile into chore/componetize-tokens-screen
Copy link
Contributor

github-actions bot commented Oct 1, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@gambinish gambinish added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 1, 2024
Copy link
Contributor

github-actions bot commented Oct 1, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: c570c2c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9a70c843-2fd2-4d27-86a1-1b4982a05dd9

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (chore/componetize-tokens-screen@31fad19). Learn more about missing BASE report.

Additional details and impacted files
@@                        Coverage Diff                         @@
##             chore/componetize-tokens-screen   #11520   +/-   ##
==================================================================
  Coverage                                   ?   53.87%           
==================================================================
  Files                                      ?     1648           
  Lines                                      ?    38241           
  Branches                                   ?     4639           
==================================================================
  Hits                                       ?    20601           
  Misses                                     ?    16227           
  Partials                                   ?     1413           
Flag Coverage Δ
53.87% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gambinish gambinish marked this pull request as ready for review October 1, 2024 05:09
Daniel-Cross
Daniel-Cross previously approved these changes Oct 16, 2024
Copy link
Contributor

@Daniel-Cross Daniel-Cross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

salimtb
salimtb previously approved these changes Oct 16, 2024
@gambinish gambinish added this pull request to the merge queue Oct 16, 2024
@gambinish gambinish removed this pull request from the merge queue due to a manual request Oct 16, 2024
@gambinish gambinish dismissed stale reviews from salimtb, Daniel-Cross, and vinnyhoward via a5d8b71 October 16, 2024 17:42
@gambinish gambinish added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 16, 2024
Copy link
Contributor

github-actions bot commented Oct 16, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 96436be
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/47596b54-61c6-4655-90ae-bc0d264a3e3f

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@gambinish gambinish added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 17, 2024
Copy link
Contributor

github-actions bot commented Oct 17, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: da5862d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/50bd8ceb-5e73-44dd-b998-57a6bbadc9bb

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@gambinish gambinish enabled auto-merge October 17, 2024 20:56
Copy link

@gambinish gambinish added this pull request to the merge queue Oct 17, 2024
Merged via the queue into main with commit 0783764 Oct 17, 2024
41 checks passed
@gambinish gambinish deleted the feat/mmassets_357-sort-import-tokens-mobile--reorg-portfolio-balance branch October 17, 2024 22:04
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2024
@metamaskbot metamaskbot added the release-7.35.0 Issue or pull request that will be included in release 7.35.0 label Oct 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.35.0 Issue or pull request that will be included in release 7.35.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants