feat: display snap name #11511

k-g-j · 2024-09-30T20:51:17Z

Description

This PR updates the display of snap accounts in the MetaMask mobile app. Previously, all snap accounts were shown with a generic “Snaps (Beta)” label. This change replaces the generic label with the specific name of the snap when available, providing users with clearer and more useful information about their snap accounts.

Key changes include:

Creation of the getInternalAccountByAddress utility function to retrieve account information of the InternalAccount type.
Modification of getAccountLabelTextByKeyring to return the snap name for snap accounts, or “Snaps (Beta)” if the name is unavailable.
Updates to affected components to display the correct snap name in the account list.
Unit tests added to verify the new functionality.

Related issues

Fixes: https://github.com/MetaMask/accounts-planning/issues/603

Manual testing steps

Build the mobile client in Flask
Navigate to the SSK dapp, install the snap, and create a snap account
Open the account list
You should see a tag under your new snap account that says "MetaMask Simple Snap Keyring"
Note: we do not have any snaps yet that do not have names, so we will need to rely on the jest unit tests for the "Snaps (Beta)" rendering behavior

Screenshots/Recordings

Before

After

Pre-merge author checklist

I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I’ve completed the PR template to the best of my ability.
I’ve included unit tests to cover the new behavior.
I’ve documented my code using JSDoc format if applicable.
I’ve applied the correct labels on the PR (see labeling guidelines).

Pre-merge reviewer checklist

I’ve manually tested the PR by running the app and testing the modified behavior.
I confirm that this PR addresses all acceptance criteria described in the issue and includes the necessary testing evidence such as screenshots and recordings.

github-actions · 2024-09-30T20:51:28Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

owencraston

Looks great!

github-actions · 2024-10-18T16:44:26Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 73b5448
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/72595d2b-4574-4631-9b48-72e0642ebba9

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

jpuri

Changes in files owned by confirmations team look good.

github-actions · 2024-10-24T20:50:20Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: a8172bc
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ac68cbd6-42d3-4589-8b4b-71962e706570

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions · 2024-10-25T20:48:52Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 51e8d6f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/49bee9d8-1edb-4550-b4e3-746384b0e42a

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

owencraston · 2024-11-07T21:38:33Z

Based on design discussion with @brianacnguyen and @eriknson we have decided to move the account type pill below the address in the send flow to match how it looks in the main address list.

github-actions · 2024-11-07T21:40:11Z

Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: b7d1a9f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d764eda8-d182-45ee-abc6-78e47e94e2cc

Note

This comment will auto-update when build completes
You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions · 2024-11-07T21:47:15Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: edda460
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e7f4fef9-b1cf-4362-812b-cc6e4335be69

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

sonarqubecloud · 2024-11-07T21:56:13Z

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
75.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Cal-L

LGTM

k-g-j force-pushed the feat/display-snap-name branch from 33f78fd to 2a6239b Compare October 15, 2024 20:49

k-g-j added team-accounts area-UI mobile-snaps labels Oct 16, 2024

k-g-j marked this pull request as ready for review October 16, 2024 15:20

k-g-j requested review from a team as code owners October 16, 2024 15:20

owencraston previously approved these changes Oct 17, 2024

View reviewed changes

k-g-j added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 18, 2024

jpuri previously approved these changes Oct 18, 2024

View reviewed changes

k-g-j enabled auto-merge October 18, 2024 17:54

owencraston force-pushed the feat/display-snap-name branch from 80e9b96 to 7e1653b Compare October 18, 2024 19:26

brianacnguyen previously approved these changes Oct 23, 2024

View reviewed changes

k-g-j removed the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 24, 2024

k-g-j dismissed stale reviews from owencraston, brianacnguyen, and jpuri via a8172bc October 24, 2024 20:44

k-g-j added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 24, 2024

k-g-j removed the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 24, 2024

owencraston added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 25, 2024

owencraston previously approved these changes Oct 25, 2024

View reviewed changes

owencraston force-pushed the feat/display-snap-name branch from 51e8d6f to d403cae Compare November 5, 2024 02:55

owencraston added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 5, 2024

k-g-j and others added 3 commits November 7, 2024 13:01

feat: more test updates

8116b3e

rebase

3ac387b

remove no shadow eslint

147696d

owencraston force-pushed the feat/display-snap-name branch from f450b1a to 147696d Compare November 7, 2024 21:01

move account type pill below address

b7d1a9f

metamaskbot added external-contributor INVALID-PR-TEMPLATE PR's body doesn't match template labels Nov 7, 2024

owencraston added Run Smoke E2E Triggers smoke e2e on Bitrise and removed INVALID-PR-TEMPLATE PR's body doesn't match template Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 7, 2024

move account label below address

edda460

metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Nov 7, 2024

owencraston added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 7, 2024

brianacnguyen approved these changes Nov 7, 2024

View reviewed changes

Cal-L approved these changes Nov 7, 2024

View reviewed changes

owencraston disabled auto-merge November 8, 2024 00:31

owencraston added this pull request to the merge queue Nov 8, 2024

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 8, 2024

owencraston added this pull request to the merge queue Nov 8, 2024

Merged via the queue into main with commit 1c27676 Nov 8, 2024
48 checks passed

owencraston deleted the feat/display-snap-name branch November 8, 2024 01:32

github-actions bot locked and limited conversation to collaborators Nov 8, 2024

metamaskbot added the release-9.100.91 label Nov 8, 2024

gauthierpetetin added the release-7.36.0 Issue or pull request that will be included in release 7.36.0 label Nov 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: display snap name #11511

feat: display snap name #11511

k-g-j commented Sep 30, 2024 •

edited by owencraston

Loading

github-actions bot commented Sep 30, 2024

owencraston left a comment

github-actions bot commented Oct 18, 2024 •

edited by metamaskbot

Loading

jpuri left a comment

github-actions bot commented Oct 24, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Oct 25, 2024 •

edited by metamaskbot

Loading

owencraston commented Nov 7, 2024 •

edited

Loading

github-actions bot commented Nov 7, 2024

github-actions bot commented Nov 7, 2024 •

edited by metamaskbot

Loading

sonarqubecloud bot commented Nov 7, 2024

Cal-L left a comment

feat: display snap name #11511

feat: display snap name #11511

Conversation

k-g-j commented Sep 30, 2024 • edited by owencraston Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

github-actions bot commented Sep 30, 2024

owencraston left a comment

Choose a reason for hiding this comment

github-actions bot commented Oct 18, 2024 • edited by metamaskbot Loading

Bitrise

jpuri left a comment

Choose a reason for hiding this comment

github-actions bot commented Oct 24, 2024 • edited by metamaskbot Loading

Bitrise

github-actions bot commented Oct 25, 2024 • edited by metamaskbot Loading

Bitrise

owencraston commented Nov 7, 2024 • edited Loading

github-actions bot commented Nov 7, 2024

Bitrise

github-actions bot commented Nov 7, 2024 • edited by metamaskbot Loading

Bitrise

sonarqubecloud bot commented Nov 7, 2024

Quality Gate passed

Cal-L left a comment

Choose a reason for hiding this comment

k-g-j commented Sep 30, 2024 •

edited by owencraston

Loading

github-actions bot commented Oct 18, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Oct 24, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Oct 25, 2024 •

edited by metamaskbot

Loading

owencraston commented Nov 7, 2024 •

edited

Loading

github-actions bot commented Nov 7, 2024 •

edited by metamaskbot

Loading