Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 10550 Re-introduce test for measuring cold app start + JS bundle load time #11507

Merged
merged 53 commits into from
Sep 30, 2024

Conversation

MarioAslau
Copy link
Contributor

Description

Using react-native-performance as a performance measurement tool, which will be implemented here - #10521, we want to utilize E2E world for measuring cold app start + JS bundle load time.

Technical Details

  • Add E2E test that measures The new App Start time in ColdStartToOnboardingScreen.feature replacing the old test
  • Added a baseline measure to compare App Start time against.
    Values from 10 tests:
    //test 1: 383
    //test 2: 334
    //test 3: 380
    //test 4: 410
    //test 5: 394
    //test 6: 352
    //test 7: 602
    //test 8: 364
    //test 9: 359
    //test 10: 438
  • E2E test check the performance numbers against the baseline value. If the new performance numbers is higher than the threshold, fail the test and vice versa

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@MarioAslau MarioAslau added the Run Smoke E2E Triggers smoke e2e on Bitrise label Sep 30, 2024
@MarioAslau MarioAslau marked this pull request as ready for review September 30, 2024 16:47
@MarioAslau MarioAslau requested a review from a team as a code owner September 30, 2024 16:47
Copy link
Contributor

github-actions bot commented Sep 30, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 9d50621
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5c2e723a-b6f1-4a15-bc3c-9e7e61aea5cd

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@MarioAslau MarioAslau added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 30, 2024
Copy link
Contributor

github-actions bot commented Sep 30, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 0415b27
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0caa17fd-5a2d-4dee-8924-bbcfb3e7b8f3

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@MarioAslau MarioAslau added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 30, 2024
Copy link
Contributor

github-actions bot commented Sep 30, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: ab5b947
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b349b5ff-547a-49e6-b87d-d2aaf23a6cb7

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@MarioAslau MarioAslau added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 30, 2024
Copy link
Contributor

github-actions bot commented Sep 30, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 1c5cdd3
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/aeaf8f7d-828a-4610-8001-0144592a6575

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 🌮 🌮

@Cal-L Cal-L added this pull request to the merge queue Sep 30, 2024
Merged via the queue into main with commit c688932 Sep 30, 2024
42 checks passed
@Cal-L Cal-L deleted the feat/10550-reintroduce-coldAppStart-test branch September 30, 2024 23:00
@github-actions github-actions bot locked and limited conversation to collaborators Sep 30, 2024
@gauthierpetetin gauthierpetetin added the release-7.33.0 Issue or pull request that will be included in release 7.33.0 label Oct 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.33.0 Issue or pull request that will be included in release 7.33.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants