Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revert measuring with react native performance #11504

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

tommasini
Copy link
Contributor

Description

Revert of this PR: #11387

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 30, 2024
@tommasini tommasini requested a review from a team as a code owner September 30, 2024 15:26
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

github-actions bot commented Sep 30, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 8fc0d9a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e26b3357-6940-42a3-af85-e1325344bec1

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ ✅ ✅

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
30.0% Coverage on New Code (required ≥ 40%)

See analysis details on SonarCloud

@tommasini tommasini added the skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. label Sep 30, 2024
@tommasini tommasini added this pull request to the merge queue Sep 30, 2024
Merged via the queue into main with commit 98f656f Sep 30, 2024
50 of 52 checks passed
@tommasini tommasini deleted the fix/revert-measuring-with-rn-performance branch September 30, 2024 16:17
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 30, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 30, 2024
@gauthierpetetin gauthierpetetin added the release-7.33.0 Issue or pull request that will be included in release 7.33.0 label Oct 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.33.0 Issue or pull request that will be included in release 7.33.0 Run Smoke E2E Triggers smoke e2e on Bitrise skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants