Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix asset symbol for incoming tx #11495

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

sahar-fehri
Copy link
Contributor

@sahar-fehri sahar-fehri commented Sep 30, 2024

Description

This PR fixes the assets symbol displayed in the incoming transaction notification.

Related issues

Fixes: #7669

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sahar-fehri sahar-fehri added needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 30, 2024
Copy link
Contributor

github-actions bot commented Sep 30, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 327cbd1
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a6d48535-878e-4abc-abcd-cf47ee5f47fc

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

@sahar-fehri sahar-fehri marked this pull request as ready for review October 1, 2024 15:24
@sahar-fehri sahar-fehri requested a review from a team as a code owner October 1, 2024 15:24
@sahar-fehri sahar-fehri added this pull request to the merge queue Oct 9, 2024
Merged via the queue into main with commit f35f102 Oct 9, 2024
47 of 48 checks passed
@sahar-fehri sahar-fehri deleted the fix/fix-symbol-in-transaction-notification branch October 9, 2024 10:40
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-7.34.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug]: Incorrect token in Receive notification: You received xxx ETH on Polygon network
4 participants