Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(revert): Prevent redundant Sentry sourcemap uploads #11492

Merged
merged 1 commit into from
Sep 27, 2024
Merged

chore(revert): Prevent redundant Sentry sourcemap uploads #11492

merged 1 commit into from
Sep 27, 2024

Conversation

sethkfman
Copy link
Contributor

Reverts #11081

@sethkfman sethkfman requested review from a team as code owners September 27, 2024 20:57
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Cal-L
Cal-L approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Sep 27, 2024
@sethkfman sethkfman changed the title Revert "chore: Prevent redundant Sentry sourcemap uploads" chore(revert): Prevent redundant Sentry sourcemap uploads Sep 27, 2024
@sethkfman sethkfman added the No QA Needed Apply this label when your PR does not need any QA effort. label Sep 27, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sethkfman sethkfman added this pull request to the merge queue Sep 27, 2024
Merged via the queue into main with commit dda0230 Sep 27, 2024
44 of 48 checks passed
@sethkfman sethkfman deleted the revert-11081-10812-prevent-redundant-sentry-sourcemap-uploads branch September 27, 2024 21:49
@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2024
@gauthierpetetin gauthierpetetin added the release-7.33.0 Issue or pull request that will be included in release 7.33.0 label Oct 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Cal-L Cal-L Cal-L approved these changes

Assignees
No one assigned
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template No QA Needed Apply this label when your PR does not need any QA effort. release-7.33.0 Issue or pull request that will be included in release 7.33.0 team-mobile-platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sethkfman @Cal-L @gauthierpetetin @metamaskbot