Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor e2e #11483

Merged
merged 1 commit into from
Sep 27, 2024
Merged

chore: refactor e2e #11483

merged 1 commit into from
Sep 27, 2024

Conversation

Jonathansoufer
Copy link
Contributor

@Jonathansoufer Jonathansoufer commented Sep 27, 2024

Description

Related issues

Fixes: 11448

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Jonathansoufer Jonathansoufer added team-mobile-platform Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 27, 2024
@Jonathansoufer Jonathansoufer self-assigned this Sep 27, 2024
@Jonathansoufer Jonathansoufer requested a review from a team as a code owner September 27, 2024 15:02
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the team-snaps-platform Snaps Platform team label Sep 27, 2024
Copy link
Contributor

github-actions bot commented Sep 27, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 63aab3f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a7c13cdf-bfa7-4937-8f93-a1dd9616a702

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

Copy link
Contributor

@SamuelSalas SamuelSalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jonathansoufer Jonathansoufer added this pull request to the merge queue Sep 27, 2024
Merged via the queue into main with commit f4792db Sep 27, 2024
49 checks passed
@Jonathansoufer Jonathansoufer deleted the fix/e2e-page-pattern branch September 27, 2024 19:16
@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2024
@metamaskbot metamaskbot added the release-7.33.0 Issue or pull request that will be included in release 7.33.0 label Sep 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.33.0 Issue or pull request that will be included in release 7.33.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform team-snaps-platform Snaps Platform team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug]: Refactor EnableDeviceNotificationsAlert.js file to follow the correct
4 participants