Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding title to confirmation page #11478

Merged
merged 2 commits into from
Sep 28, 2024
Merged

feat: adding title to confirmation page #11478

merged 2 commits into from
Sep 28, 2024

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Sep 27, 2024

Description

Adding title to confirmations page.

Related issues

Fixes: #11435

Manual testing steps

  1. Enable re-designed confirmations locally
  2. Go to test dapp and submit personal sign
  3. Check title on new confirmation page

Screenshots/Recordings

Screenshot 2024-09-27 at 8 00 53 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team labels Sep 27, 2024
@jpuri jpuri requested review from a team as code owners September 27, 2024 14:37
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 9573a86
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1d2dae9b-49db-4bba-b409-f55f56b0d085

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@jpuri jpuri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 27, 2024
Copy link
Contributor

github-actions bot commented Sep 27, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 01e3b73
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/342718f4-7236-4094-907d-15810f05b28a

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

@jpuri jpuri enabled auto-merge September 27, 2024 15:49
@jpuri jpuri added this pull request to the merge queue Sep 28, 2024
Merged via the queue into main with commit a14ccbf Sep 28, 2024
42 checks passed
@jpuri jpuri deleted the confirmation_title branch September 28, 2024 10:14
@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2024
@gauthierpetetin gauthierpetetin added the release-7.33.0 Issue or pull request that will be included in release 7.33.0 label Oct 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.33.0 Issue or pull request that will be included in release 7.33.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create generic title component for confirmation pages
4 participants