Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding footer section to confirmation page #11477

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Sep 27, 2024

Description

Adding generic footer section to confirmation page.

Related issues

Fixes: #11434

Manual testing steps

  1. Locally enable export REDESIGNED_SIGNATURE_REQUEST="true"
  2. Go to test dapp and submit personal sign request
  3. New confirmation page with footer should be visible

Screenshots/Recordings

Screenshot 2024-09-27 at 5 41 43 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added the team-confirmations Push issues to confirmations team label Sep 27, 2024
@jpuri jpuri requested review from a team as code owners September 27, 2024 12:16
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

@jpuri jpuri added the Run Smoke E2E Triggers smoke e2e on Bitrise label Sep 27, 2024
Copy link
Contributor

github-actions bot commented Sep 27, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 995c64a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d3bb8afc-4277-44ea-808b-1026c5607955

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@jpuri jpuri added this pull request to the merge queue Sep 27, 2024
Merged via the queue into main with commit c3642ca Sep 27, 2024
43 of 45 checks passed
@jpuri jpuri deleted the confirmation_footer branch September 27, 2024 13:32
@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2024
@metamaskbot metamaskbot added the release-7.33.0 Issue or pull request that will be included in release 7.33.0 label Sep 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.33.0 Issue or pull request that will be included in release 7.33.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create footer component for confirmation pages
4 participants