Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(js-ts): Convert app/components/Base/ModalHandler.js to TypeScript #11473

Merged
merged 6 commits into from
Oct 3, 2024
Merged

chore(js-ts): Convert app/components/Base/ModalHandler.js to TypeScript #11473

merged 6 commits into from
Oct 3, 2024

Conversation

devin-ai-integration[bot]
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Sep 27, 2024 •
edited
Loading

PR Title

chore(js-ts): Convert app/components/Base/ModalHandler.js to TypeScript

Description

This PR converts the ModalHandler.js file to TypeScript, ensuring type safety and improved code maintainability.

Link to Devin run

https://preview.devin.ai/devin/78ca348f567346319ced52ecb605e2b9

Related Issues

N/A

Manual Testing Steps

  1. Verify that the modal functionality works as expected in the application.
  2. Ensure there are no TypeScript errors in the converted file.

Author Checklist

  • Code is converted to TypeScript.
  • No TypeScript errors are present.
  • Linting passes without errors.

Reviewer Checklist

  • Code is correctly converted to TypeScript.
  • No TypeScript errors are present.
  • Linting passes without errors.

This Devin run was requested by naveen.

If you have any feedback, you can leave comments in the PR and I'll address them in the app!

@devin-ai-integration devin-ai-integration bot added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform No QA Needed Apply this label when your PR does not need any QA effort. labels Sep 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the team-ai AI team (for the Devin AI bot) label Sep 27, 2024
@devin-ai-integration devin-ai-integration bot added the skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. label Sep 27, 2024
@devin-ai-integration devin-ai-integration bot marked this pull request as ready for review October 1, 2024 08:06
@devin-ai-integration devin-ai-integration bot requested a review from a team as a code owner October 1, 2024 08:06
@smilingkylan smilingkylan added skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. and removed skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. labels Oct 2, 2024
smilingkylan
smilingkylan approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@smilingkylan smilingkylan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smilingkylan smilingkylan added skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. and removed skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. labels Oct 3, 2024
@smilingkylan smilingkylan requested a review from a team as a code owner October 3, 2024 18:11
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 3, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 40%)

See analysis details on SonarCloud

@smilingkylan smilingkylan enabled auto-merge October 3, 2024 18:23
@smilingkylan smilingkylan added skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. and removed skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. labels Oct 3, 2024
@smilingkylan smilingkylan disabled auto-merge October 3, 2024 18:24
@smilingkylan smilingkylan enabled auto-merge October 3, 2024 18:24
@smilingkylan smilingkylan added this pull request to the merge queue Oct 3, 2024
Merged via the queue into main with commit 6c4afcc Oct 3, 2024
42 of 43 checks passed
@smilingkylan smilingkylan deleted the devin/convert-ts-app-components-base-modalhandler-13588 branch October 3, 2024 19:02
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 3, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 3, 2024
@gauthierpetetin gauthierpetetin added the release-7.33.0 Issue or pull request that will be included in release 7.33.0 label Oct 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vinnyhoward vinnyhoward vinnyhoward approved these changes

@smilingkylan smilingkylan smilingkylan approved these changes

Assignees
No one assigned
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.33.0 Issue or pull request that will be included in release 7.33.0 skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. team-ai AI team (for the Devin AI bot) team-mobile-platform
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smilingkylan @vinnyhoward @gauthierpetetin