Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Remove E2E Tests for Features No Longer Present in the App #11469

Merged

Conversation

SamuelSalas
Copy link
Contributor

Description

This task aims to remove the add-edit-custom-eth-mainnet test and the contract-nickname test from the quarantine folder. We no longer have feature support for these areas and we should remove the associated e2e test to clean up the quarantine folder.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@SamuelSalas SamuelSalas self-assigned this Sep 26, 2024
@SamuelSalas SamuelSalas requested a review from a team as a code owner September 26, 2024 23:22
@SamuelSalas SamuelSalas added the Run Smoke E2E Triggers smoke e2e on Bitrise label Sep 26, 2024
Copy link
Contributor

github-actions bot commented Sep 26, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 9cf7bfd
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ccfcf122-0494-41a7-84f1-b3867b90df25

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Copy link

Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY!

@SamuelSalas SamuelSalas added this pull request to the merge queue Sep 27, 2024
Merged via the queue into main with commit 515b04b Sep 27, 2024
48 of 49 checks passed
@SamuelSalas SamuelSalas deleted the test/1939-remove-e2e-tests-for-depricated-features branch September 27, 2024 17:51
@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2024
@metamaskbot metamaskbot added the release-7.33.0 Issue or pull request that will be included in release 7.33.0 label Sep 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Detox release-7.33.0 Issue or pull request that will be included in release 7.33.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants