Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: STAKE-804: build pooled staking empty state component #11464

Merged

Conversation

Matt561
Copy link
Contributor

@Matt561 Matt561 commented Sep 26, 2024

Description

  • Adds the staking cta (empty state) when the user is currently not staking ETH.
  • Added conditional rendering in <StakingBalance /> based on whether the user if geo-blocked or not.

Related issues

Ticket: STAKE-804: [FE] Build pooled staking empty state component

Manual testing steps

  1. Set MM_POOLED_STAKING_UI_ENABLED=true in your local .js.env
  2. Click on Ethereum in the asset list
  3. Scroll down until you see the "Stake ETH and earn" section

Screenshots/Recordings

Before

stake-804-build-pooled-staking-empty-state-component-before-demo.mov

After

Staking CTA Demo

stake-804-build-pooled-staking-empty-state-component-after-demo.mov

Geo-Blocked User Demo

image

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Matt561 Matt561 force-pushed the feat/stake-804-build-pooled-staking-empty-state-component branch from a89d1d2 to 5972d9c Compare September 26, 2024 17:35
@Matt561 Matt561 force-pushed the feat/stake-804-build-pooled-staking-empty-state-component branch from 5972d9c to 98b2424 Compare September 26, 2024 17:37
@Matt561 Matt561 marked this pull request as ready for review September 26, 2024 20:37
@Matt561 Matt561 requested review from a team as code owners September 26, 2024 20:37
@Matt561 Matt561 force-pushed the feat/stake-804-build-pooled-staking-empty-state-component branch from 8b68e94 to e54b6fc Compare September 26, 2024 21:08
@Matt561 Matt561 force-pushed the feat/stake-804-build-pooled-staking-empty-state-component branch from 2b7f99b to 30433aa Compare September 27, 2024 14:14
@Matt561 Matt561 force-pushed the feat/stake-804-build-pooled-staking-empty-state-component branch from 30433aa to d26e795 Compare September 27, 2024 14:15
Copy link
Contributor

@amitabh94 amitabh94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments but overall LGTM! 👏🏼

@Matt561 Matt561 requested a review from amitabh94 September 27, 2024 15:49
Copy link

@Matt561 Matt561 added the Run Smoke E2E Triggers smoke e2e on Bitrise label Sep 27, 2024
Copy link
Contributor

github-actions bot commented Sep 27, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 64407f6
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/48eeed12-5db4-4329-b2fc-932291b85075

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link
Contributor

@amitabh94 amitabh94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Matt561 Matt561 added this pull request to the merge queue Sep 27, 2024
@Matt561 Matt561 removed this pull request from the merge queue due to a manual request Sep 27, 2024
@Matt561 Matt561 added this pull request to the merge queue Sep 27, 2024
Merged via the queue into main with commit 95cb2d1 Sep 27, 2024
38 of 39 checks passed
@Matt561 Matt561 deleted the feat/stake-804-build-pooled-staking-empty-state-component branch September 27, 2024 19:27
@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2024
@gauthierpetetin gauthierpetetin added the release-7.33.0 Issue or pull request that will be included in release 7.33.0 label Oct 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.33.0 Issue or pull request that will be included in release 7.33.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-stake
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants