test: Merge Import Token flow methods and ids in just one folder and files

[SamuelSalas]

Description

We are aiming to refactor the page objects in the modal folder so that they strictly follow the page object model pattern. This would aide in providing more readable and help standardize the way we create our tests. Because of the amount of files remaining, this issue will focus on working on three files to refactor, as well as their respective testIDS.

While doing some analysis we see that the ImportTokens and AddCustomTokenView classes could be merge together. So the refactoring of the test and classes should be implemented on both files.

NOTE: You should move the AddCustomTokenView and ImportTokens files into a token-import subfolder within the wallet folder for better organization and clarity.

Related issues

Fixes:

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Regressin test runs: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ca857ba6-cebc-4903-8918-3d7dc3a51a36

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 2c92708
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f1da08cb-588e-4155-a789-774a57e5e45a

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[cortisiko]

Small feedback, otherwise looks good

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: be6ce96
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0326d1a5-200c-4902-aeaa-a9f33ce3a4c9

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 6c64ae2
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/92cfd357-fd63-49c9-8b2e-293a920eac7e

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[cortisiko]

🌮 🌮

[Daniel-Cross]

Really nice use of constants for these testId's. I like it. One small fix to address but I'll approve.

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 90d2dbd
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2829c818-bdf2-4737-b6fb-f107be183e2e

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[gambinish]

Code looks good. Approving, but when I was trying to run CI locally, I was getting a failed build:

** BUILD FAILED **


The following build commands failed:
	CompileC /Users/nicholasgambino/code/metamask-mobile/ios/build/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/RNDateTimePicker.build/Objects-normal/x86_64/RNDateTimePickerShadowView.o /Users/nicholasgambino/code/metamask-mobile/node_modules/@react-native-community/datetimepicker/ios/RNDateTimePickerShadowView.m normal x86_64 objective-c com.apple.compilers.llvm.clang.1_0.compiler (in target 'RNDateTimePicker' from project 'Pods')
(1 failure)
error Command failed with exit code 65.

Steps I took:

git pull
yarn setup:e2e
yarn start:ios:e2e

Approving now bc this feels unrelated, and CI tests are passing in Github. Will reach out in Slack for help.