Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add metric for insufficient funds for gas #11456

Merged
merged 8 commits into from
Oct 7, 2024
Merged

feat: Add metric for insufficient funds for gas #11456

merged 8 commits into from
Oct 7, 2024

Conversation

OGPoyraz
Copy link
Member

Description

This PR adds an extra field for transaction metrics when user gets insufficient funds for gas error in app.
Also adjusting the validation code a bit to improve readability and maintainability.

Related issues

More context: https://github.com/MetaMask/MetaMask-planning/issues/2773

Manual testing steps

No QA needed

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@OGPoyraz OGPoyraz requested review from a team as code owners September 26, 2024 10:08
@github-actions github-actions bot added the team-confirmations Push issues to confirmations team label Sep 26, 2024
@OGPoyraz OGPoyraz added No QA Needed Apply this label when your PR does not need any QA effort. Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 26, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 847f418
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0c724318-b9cf-49a0-8f08-30d251af4895

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

matthewwalsh0
matthewwalsh0 previously approved these changes Sep 26, 2024
View reviewed changes
@OGPoyraz OGPoyraz added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 30, 2024
NicolasMassart
NicolasMassart previously approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@NicolasMassart NicolasMassart left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me when it has enough coverage.

@OGPoyraz OGPoyraz enabled auto-merge October 2, 2024 11:11
@OGPoyraz OGPoyraz added the skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. label Oct 7, 2024
@OGPoyraz OGPoyraz disabled auto-merge October 7, 2024 09:24
@OGPoyraz OGPoyraz removed the skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. label Oct 7, 2024
@OGPoyraz OGPoyraz added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 7, 2024

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 69985ee
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5835ccf1-2db3-4122-bc8c-c5572d50e7c4

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@OGPoyraz OGPoyraz removed the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 7, 2024
@OGPoyraz OGPoyraz added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 7, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 8480491
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/25558bbe-3d71-4d7c-a093-73224c7cdd4a

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
60.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@OGPoyraz OGPoyraz added this pull request to the merge queue Oct 7, 2024
Merged via the queue into main with commit 0c92657 Oct 7, 2024
43 checks passed
@OGPoyraz OGPoyraz deleted the 2773-add-metric-for-insufficient-funds-for-gas-warning-on-mobile branch October 7, 2024 14:29
@github-actions github-actions bot locked and limited conversation to collaborators Oct 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vinistevam vinistevam vinistevam approved these changes

@jpuri jpuri jpuri approved these changes

@matthewwalsh0 matthewwalsh0 matthewwalsh0 left review comments

@pedronfigueiredo pedronfigueiredo pedronfigueiredo left review comments

@NicolasMassart NicolasMassart NicolasMassart left review comments

Assignees
No one assigned
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.34.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@OGPoyraz @jpuri @NicolasMassart @pedronfigueiredo @matthewwalsh0 @vinistevam @gauthierpetetin