Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding very basic confirmation page hidden behind env var #11454

Merged
merged 4 commits into from
Sep 26, 2024

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Sep 26, 2024

Description

Adding a very basic confirmation page hidden behind env flag.

Related issues

Fixes: #11438

Manual testing steps

NA

Screenshots/Recordings

Screen.Recording.2024-09-25.at.10.07.23.PM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team labels Sep 26, 2024
@jpuri jpuri requested review from a team as code owners September 26, 2024 09:56
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpuri jpuri changed the title feat: adding very basic confirmation page feat: adding very basic confirmation page hidden behind env var Sep 26, 2024
Copy link
Contributor

github-actions bot commented Sep 26, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 6a1bc54
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0d009722-8832-49b6-99c3-d2914e881c44

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

@jpuri jpuri requested a review from matthewwalsh0 September 26, 2024 11:36
@jpuri jpuri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 26, 2024
Copy link
Contributor

github-actions bot commented Sep 26, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: f505542
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/62da8d05-22eb-4644-84f5-c99f63ef2a85

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@jpuri jpuri added this pull request to the merge queue Sep 26, 2024
Merged via the queue into main with commit ed7fe2e Sep 26, 2024
41 of 42 checks passed
@jpuri jpuri deleted the basic_confirmation_page branch September 26, 2024 12:05
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2024
@metamaskbot metamaskbot added the release-7.33.0 Issue or pull request that will be included in release 7.33.0 label Sep 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.33.0 Issue or pull request that will be included in release 7.33.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create very basic re-designed confirmation root page page hidden behind env variable
4 participants