feat: Add signature tracing #11453

OGPoyraz · 2024-09-26T08:11:35Z

Description

Adding createTracingMiddleware to start tracing for defined type of messages.
Adding trace callback to SignatureController.
End Notification Display trace after signature confirmation landed on users screen.

Related issues

Fixes: https://github.com/MetaMask/mobile-planning/issues/1883

Manual testing steps

Set MM_SENTRY_DSN_DEV to developer Sentry dsn, see the value here https://github.com/MetaMask/metamask-extension/blob/develop/.metamaskrc.dist
Go test-dapp in app, trigger and personal signature
If you used the mentioned dsn above, your Signature trace will appear on this link: https://metamask.sentry.io/traces/?project=273496&query=signature%3ATransaction&source=traces&statsPeriod=1h

Screenshots/Recordings

Before

After

Pre-merge author checklist

I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…equests-in-mobile

github-actions · 2024-09-26T08:59:03Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 7e7823e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/66431eff-be4e-4076-86ff-2ac6ffcf169c

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

app/components/Approvals/SignatureApproval/SignatureApproval.tsx

app/core/RPCMethods/RPCMethodMiddleware.ts

…equests-in-mobile

sonarqubecloud · 2024-10-04T09:56:59Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
92.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions · 2024-10-07T07:57:00Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: db91a0d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/56a2426f-530b-46c1-86d6-1bf053dc99ad

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

andreahaku

some optimisations suggested

app/core/createTracingMiddleware/index.ts

andreahaku

LGTM

NicolasMassart · 2024-10-08T09:44:24Z

app/core/RPCMethods/RPCMethodMiddleware.test.ts

C: This test file covers the new code changes, but doesn't test it.
If it's important to make sure trace is called, you could spy on it.

NicolasMassart · 2024-10-08T09:49:25Z

app/components/Views/confirmations/components/SignatureRequest/Root/Root.tsx

@@ -2,6 +2,7 @@ import Modal from 'react-native-modal';
 import React, { useEffect, useState } from 'react';
 import { StyleSheet } from 'react-native';
 import { useNavigation } from '@react-navigation/native';
+import { useSelector } from 'react-redux';


C: This should not be in the PR. If it was a file you worked on, reorganising imports is fine, but if it's only the import change, you may leave it as is.

NicolasMassart · 2024-10-08T09:51:25Z

app/components/Approvals/SignatureApproval/SignatureApproval.tsx

S: add a test case and spy on endTrace in app/components/Approvals/SignatureApproval/SignatureApproval.test.tsx

OGPoyraz added 2 commits September 26, 2024 09:56

Add signature tracing

83f6750

add trace callback

15c179a

OGPoyraz requested review from a team as code owners September 26, 2024 08:11

github-actions bot added the team-confirmations Push issues to confirmations team label Sep 26, 2024

OGPoyraz added 3 commits September 26, 2024 10:13

Add comment

c6b4d38

Fix lint

4446959

Merge branch 'main' into 1883-add-performance-metrics-for-signature-r…

7296ae0

…equests-in-mobile

OGPoyraz added the No QA Needed Apply this label when your PR does not need any QA effort. label Sep 26, 2024

OGPoyraz added 2 commits September 26, 2024 10:24

fix test

d057315

Fix test

7e7823e

OGPoyraz added the Run Smoke E2E Triggers smoke e2e on Bitrise label Sep 26, 2024

pedronfigueiredo previously approved these changes Sep 26, 2024

View reviewed changes

vinistevam previously approved these changes Sep 26, 2024

View reviewed changes

jpuri previously approved these changes Sep 26, 2024

View reviewed changes

matthewwalsh0 requested changes Sep 26, 2024

View reviewed changes

app/components/Approvals/SignatureApproval/SignatureApproval.tsx Outdated Show resolved Hide resolved

app/components/Approvals/SignatureApproval/SignatureApproval.tsx Outdated Show resolved Hide resolved

app/core/RPCMethods/RPCMethodMiddleware.ts Show resolved Hide resolved

OGPoyraz added 2 commits September 30, 2024 12:05

Merge branch 'main' into 1883-add-performance-metrics-for-signature-r…

ea0edc6

…equests-in-mobile

Fix suggestions

a5411b0

OGPoyraz dismissed stale reviews from vinistevam, pedronfigueiredo, and jpuri via a5411b0 September 30, 2024 10:08

fix suggestion

3971aa6

matthewwalsh0 approved these changes Sep 30, 2024

View reviewed changes

OGPoyraz added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 30, 2024

Merge branch 'main' into 1883-add-performance-metrics-for-signature-r…

c6109d4

…equests-in-mobile

OGPoyraz removed the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 1, 2024

OGPoyraz added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 1, 2024

Merge branch 'main' into 1883-add-performance-metrics-for-signature-r…

7a78eaf

…equests-in-mobile

OGPoyraz added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 2, 2024

Merge branch 'main' into 1883-add-performance-metrics-for-signature-r…

db91a0d

…equests-in-mobile

OGPoyraz requested a review from a team as a code owner October 4, 2024 09:46

OGPoyraz added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 4, 2024

MetaMask deleted a comment from github-actions bot Oct 7, 2024

andreahaku reviewed Oct 7, 2024

View reviewed changes

app/core/createTracingMiddleware/index.ts Show resolved Hide resolved

app/core/createTracingMiddleware/index.ts Show resolved Hide resolved

app/core/createTracingMiddleware/index.ts Show resolved Hide resolved

andreahaku approved these changes Oct 7, 2024

View reviewed changes

tommasini approved these changes Oct 8, 2024

View reviewed changes

OGPoyraz added this pull request to the merge queue Oct 8, 2024

Merged via the queue into main with commit a11ee59 Oct 8, 2024
55 checks passed

OGPoyraz deleted the 1883-add-performance-metrics-for-signature-requests-in-mobile branch October 8, 2024 09:47

github-actions bot locked and limited conversation to collaborators Oct 8, 2024

NicolasMassart reviewed Oct 8, 2024

View reviewed changes

gauthierpetetin added the release-7.34.0 label Oct 10, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add signature tracing #11453

feat: Add signature tracing #11453

OGPoyraz commented Sep 26, 2024

github-actions bot commented Sep 26, 2024 •

edited by metamaskbot

Loading

sonarqubecloud bot commented Oct 4, 2024

github-actions bot commented Oct 7, 2024 •

edited by metamaskbot

Loading

andreahaku left a comment

andreahaku left a comment

NicolasMassart Oct 8, 2024

NicolasMassart Oct 8, 2024

NicolasMassart Oct 8, 2024

feat: Add signature tracing #11453

feat: Add signature tracing #11453

Conversation

OGPoyraz commented Sep 26, 2024

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Sep 26, 2024 • edited by metamaskbot Loading

Bitrise

sonarqubecloud bot commented Oct 4, 2024

Quality Gate passed

github-actions bot commented Oct 7, 2024 • edited by metamaskbot Loading

Bitrise

andreahaku left a comment

Choose a reason for hiding this comment

andreahaku left a comment

Choose a reason for hiding this comment

NicolasMassart Oct 8, 2024

Choose a reason for hiding this comment

NicolasMassart Oct 8, 2024

Choose a reason for hiding this comment

NicolasMassart Oct 8, 2024

Choose a reason for hiding this comment

github-actions bot commented Sep 26, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Oct 7, 2024 •

edited by metamaskbot

Loading