Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ds): add ListItem top and bottom accessories #11452

Merged
merged 10 commits into from
Oct 1, 2024

Conversation

wachunei
Copy link
Member

@wachunei wachunei commented Sep 26, 2024

Description

This PR extends ListItem component to accept topAccessory and bottomAccessory props to render a react node above or below the current list item.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

listitem.mp4

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions github-actions bot added the team-ramp issues related to Ramp features label Sep 26, 2024
@wachunei wachunei added team-design-system All issues relating to design system in Mobile and removed team-ramp issues related to Ramp features labels Sep 26, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@wachunei wachunei added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 27, 2024
@wachunei wachunei marked this pull request as ready for review September 27, 2024 18:16
@wachunei wachunei requested review from a team as code owners September 27, 2024 18:16
@wachunei wachunei added the Run Smoke E2E Triggers smoke e2e on Bitrise label Sep 27, 2024
Copy link
Contributor

github-actions bot commented Sep 27, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 1013fce
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0785104c-dbf4-47b6-8f66-f9dc2fc19dee

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@wachunei wachunei removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 1, 2024
@wachunei wachunei enabled auto-merge October 1, 2024 15:41
Copy link

sonarqubecloud bot commented Oct 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@wachunei wachunei added this pull request to the merge queue Oct 1, 2024
Merged via the queue into main with commit 433776f Oct 1, 2024
36 checks passed
@wachunei wachunei deleted the feat/list-item-accessories branch October 1, 2024 16:20
@github-actions github-actions bot locked and limited conversation to collaborators Oct 1, 2024
@gauthierpetetin gauthierpetetin added the release-7.33.0 Issue or pull request that will be included in release 7.33.0 label Oct 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.33.0 Issue or pull request that will be included in release 7.33.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-design-system All issues relating to design system in Mobile
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants