Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(js-ts): Convert app/components/Views/MediaPlayer/Loader.js to TypeScript #11446

Conversation

devin-ai-integration[bot]
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Sep 25, 2024

PR Description

Summary

This PR converts the Loader.js file to TypeScript following the playbook instructions. The conversion process involved renaming the file to Loader.tsx, adding type annotations, and ensuring no TypeScript errors remain. Additionally, the onError prop has been added and handled separately from onClose, with appropriate type annotations and implementation.

Related Issues

  • N/A

Manual Testing Steps

  1. Verify that the Loader component functions as expected in the application.
  2. Ensure that there are no TypeScript errors in the Loader.tsx file.
  3. Check that the onClose and onError props are correctly typed and function as intended.

Author Checklist

  • Converted Loader.js to Loader.tsx with appropriate type annotations.
  • Removed propTypes from the Loader.tsx file.
  • Ensured no TypeScript errors remain in the file.
  • Updated the PR description to follow the template.
  • Added and handled the onError prop separately from onClose.

Reviewer Checklist

  • Verify that the Loader component functions correctly in the application.
  • Ensure that the onClose and onError props are correctly typed and function as intended.
  • Confirm that the PR description follows the template and provides all necessary information.

@devin-ai-integration devin-ai-integration bot added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform No QA Needed Apply this label when your PR does not need any QA effort. labels Sep 25, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the team-ai AI team (for the Devin AI bot) label Sep 25, 2024
@devin-ai-integration devin-ai-integration bot added skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. and removed skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. labels Sep 25, 2024
Copy link
Contributor Author

Triggering CI rerun

Copy link
Contributor Author

The onClose prop in the Loader.tsx file is now correctly typed as () => void, consistent with the CollectibleMediaProps interface. The PR is ready for review.

@devin-ai-integration devin-ai-integration bot marked this pull request as ready for review September 26, 2024 04:59
@devin-ai-integration devin-ai-integration bot requested a review from a team as a code owner September 26, 2024 04:59
@smilingkylan smilingkylan enabled auto-merge October 3, 2024 18:11
@smilingkylan smilingkylan requested a review from a team as a code owner October 3, 2024 18:24
@smilingkylan smilingkylan added skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. and removed skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. labels Oct 3, 2024
Copy link

sonarqubecloud bot commented Oct 3, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
5.0% Coverage on New Code (required ≥ 40%)

See analysis details on SonarCloud

@smilingkylan smilingkylan added this pull request to the merge queue Oct 3, 2024
Merged via the queue into main with commit aef9a93 Oct 3, 2024
42 of 43 checks passed
@smilingkylan smilingkylan deleted the devin/convert-ts-app/components/Views/MediaPlayer/Loader.js-255 branch October 3, 2024 19:02
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 3, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 3, 2024
@gauthierpetetin gauthierpetetin added the release-7.33.0 Issue or pull request that will be included in release 7.33.0 label Oct 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.33.0 Issue or pull request that will be included in release 7.33.0 skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. team-ai AI team (for the Devin AI bot) team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants