-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(js-ts): Convert app/components/Views/MediaPlayer/Loader.js to TypeScript #11446
Merged
smilingkylan
merged 9 commits into
main
from
devin/convert-ts-app/components/Views/MediaPlayer/Loader.js-255
Oct 3, 2024
Merged
chore(js-ts): Convert app/components/Views/MediaPlayer/Loader.js to TypeScript #11446
smilingkylan
merged 9 commits into
main
from
devin/convert-ts-app/components/Views/MediaPlayer/Loader.js-255
Oct 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devin-ai-integration
bot
added
needs-dev-review
PR needs reviews from other engineers (in order to receive required approvals)
team-mobile-platform
No QA Needed
Apply this label when your PR does not need any QA effort.
labels
Sep 25, 2024
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
devin-ai-integration
bot
added
skip-sonar-cloud
Only used for bypassing sonar cloud when failures are not relevant to the changes.
and removed
skip-sonar-cloud
Only used for bypassing sonar cloud when failures are not relevant to the changes.
labels
Sep 25, 2024
Triggering CI rerun |
The |
smilingkylan
approved these changes
Sep 30, 2024
…layer/Loader.js-255
smilingkylan
added
skip-sonar-cloud
Only used for bypassing sonar cloud when failures are not relevant to the changes.
and removed
skip-sonar-cloud
Only used for bypassing sonar cloud when failures are not relevant to the changes.
labels
Oct 3, 2024
Quality Gate failedFailed conditions |
vinnyhoward
approved these changes
Oct 3, 2024
smilingkylan
deleted the
devin/convert-ts-app/components/Views/MediaPlayer/Loader.js-255
branch
October 3, 2024 19:02
github-actions
bot
removed
the
needs-dev-review
PR needs reviews from other engineers (in order to receive required approvals)
label
Oct 3, 2024
gauthierpetetin
added
the
release-7.33.0
Issue or pull request that will be included in release 7.33.0
label
Oct 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
No QA Needed
Apply this label when your PR does not need any QA effort.
release-7.33.0
Issue or pull request that will be included in release 7.33.0
skip-sonar-cloud
Only used for bypassing sonar cloud when failures are not relevant to the changes.
team-ai
AI team (for the Devin AI bot)
team-mobile-platform
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Summary
This PR converts the
Loader.js
file to TypeScript following the playbook instructions. The conversion process involved renaming the file toLoader.tsx
, adding type annotations, and ensuring no TypeScript errors remain. Additionally, theonError
prop has been added and handled separately fromonClose
, with appropriate type annotations and implementation.Related Issues
Manual Testing Steps
Loader
component functions as expected in the application.Loader.tsx
file.onClose
andonError
props are correctly typed and function as intended.Author Checklist
Loader.js
toLoader.tsx
with appropriate type annotations.propTypes
from theLoader.tsx
file.onError
prop separately fromonClose
.Reviewer Checklist
Loader
component functions correctly in the application.onClose
andonError
props are correctly typed and function as intended.