Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add the abilty to hide the disconnect all button as well as showing and hiding the accounts row when necessary #11445

Merged
merged 4 commits into from
Sep 30, 2024
Merged

feat: add the abilty to hide the disconnect all button as well as showing and hiding the accounts row when necessary #11445

merged 4 commits into from
Sep 30, 2024

Conversation

EtherWizard33
Copy link
Contributor

@EtherWizard33 EtherWizard33 commented Sep 25, 2024 •
edited
Loading

Description

Adds tracking to the user requesting network switching as well as his press of the confirmation button.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3299

Manual testing steps

  1. Go to the in app browser and open have a connected dapp for example to ethereum main net
  2. In the dapp select to change network, the modal will come up
  3. Confirm that the modal looks like the screenshot below After: WIthout Bugs

Screenshots/Recordings

Before: With Bugs After: WIthout Bugs
Screenshot 2024-04-18 at 3 56 43 PM Screenshot 2024-04-18 at 3 56 43 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@EtherWizard33 EtherWizard33 added No QA Needed Apply this label when your PR does not need any QA effort. team-wallet-ux labels Sep 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@EtherWizard33
fix: remove duplicate translations and when view is used in context n…
e63b9d8 
…etwork switching show only the expected content and hide the rest
@EtherWizard33 EtherWizard33 marked this pull request as ready for review September 25, 2024 20:04
@EtherWizard33 EtherWizard33 requested a review from a team as a code owner September 25, 2024 20:04
@EtherWizard33 EtherWizard33 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed No QA Needed Apply this label when your PR does not need any QA effort. labels Sep 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 25, 2024 •
edited
Loading

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: e63b9d8
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6ee01ed6-5257-4c13-aee0-1fa58343cef7

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@devin-ai-integration devin-ai-integration bot added skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. and removed skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. labels Sep 25, 2024
@EtherWizard33 EtherWizard33 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 25, 2024
tommasini
tommasini approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@EtherWizard33 EtherWizard33 added No QA Needed Apply this label when your PR does not need any QA effort. Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise No QA Needed Apply this label when your PR does not need any QA effort. labels Sep 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 30, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 91759f1
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d5ddd33c-00a4-4ea9-bbad-968cdc5b7a4f

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@EtherWizard33 EtherWizard33 added this pull request to the merge queue Sep 30, 2024
Merged via the queue into main with commit 0acf314 Sep 30, 2024
48 checks passed
@EtherWizard33 EtherWizard33 deleted the feat-2793-to-the-permission-summary-add-improvements-and-fixes branch September 30, 2024 20:05
@github-actions github-actions bot locked and limited conversation to collaborators Sep 30, 2024
@gauthierpetetin gauthierpetetin added the release-7.33.0 Issue or pull request that will be included in release 7.33.0 label Oct 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tommasini tommasini tommasini approved these changes

Assignees
No one assigned
Labels
release-7.33.0 Issue or pull request that will be included in release 7.33.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-wallet-ux
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EtherWizard33 @tommasini @gauthierpetetin