Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: cherry-pick fix: "chore(deps): Bump @metamask/base-controller from ^6.0.0 to ^7.0.0 (#11207)" #11439

Merged
merged 3 commits into from
Sep 26, 2024
Merged

chore: cherry-pick fix: "chore(deps): Bump @metamask/base-controller from ^6.0.0 to ^7.0.0 (#11207)" #11439

merged 3 commits into from
Sep 26, 2024

Conversation

MajorLift
Copy link
Contributor

@MajorLift MajorLift commented Sep 25, 2024 •
edited
Loading

Description

  • Cherry-picks b6d21fd into the 7.32.0 release candidate.
  • Fixes an "Unused @ts-expect-error directive" error.
    • This does not affect runtime behavior as evidenced by all unit tests and e2e tests passing before the fix commit is made.
    • Depending on the order of cherry-picking, the error in this commit may disappear and/or appear on a later commit.
      • This it because the error arises from interactions between commits that change @metamask/base-controller versions.
      • This is also why this error appears in this commit, but didn't in the original PR.
      • This is not a cause for concern, as long as the final commit results in the @ts-expect-error directive being removed.

Related issues

Fixes:

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@MajorLift @mikesposito
chore(deps): Bump @metamask/base-controller from ^6.0.0 to `^7.0.…
0df5d2b 
…0` (#11207)

## **Description**

```md
### Changed

- **BREAKING:** Bump `@metamask/base-controller` from `^6.0.0` to `^7.0.0` ([#11207](#11207))
```

## **Related issues**

- Closes #11206

## **Manual testing steps**

## **Screenshots/Recordings**

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: Michele Esposito <michele@esposito.codes>
Co-authored-by: Michele Esposito <34438276+mikesposito@users.noreply.github.com>
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@MajorLift MajorLift added the Run Smoke E2E Triggers smoke e2e on Bitrise label Sep 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 25, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 0df5d2b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2a875c76-8543-4557-8dd3-90e5c0ebd983

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@MajorLift MajorLift changed the title chore: cherry-pick "chore(deps): Bump @metamask/base-controller from ^6.0.0 to ^7.0.0 (#11207)" chore: cherry-pick fix: "chore(deps): Bump @metamask/base-controller from ^6.0.0 to ^7.0.0 (#11207)" Sep 25, 2024
@MajorLift MajorLift added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 25, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: b54bf86
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/987fa9b3-3069-41ea-bd98-594d1ea8249c

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@MajorLift MajorLift self-assigned this Sep 25, 2024
@MajorLift MajorLift added release-blocker This bug is blocking the next release release-7.32.0 Issue or pull request that will be included in release 7.32.0 labels Sep 25, 2024
@MajorLift MajorLift marked this pull request as ready for review September 25, 2024 15:50
@MajorLift MajorLift added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 25, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: bb20f0f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8f9a6c36-855b-439a-a3b3-b4cf8fb41b4b

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@devin-ai-integration devin-ai-integration bot added skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. and removed skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. labels Sep 25, 2024
sethkfman
sethkfman approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman sethkfman merged commit 95d041d into release/7.32.0 Sep 26, 2024
41 checks passed
@sethkfman sethkfman deleted the cherry-pick-b6d21fd branch September 26, 2024 16:02
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethkfman sethkfman sethkfman approved these changes

Assignees

@MajorLift MajorLift

Labels
release-7.32.0 Issue or pull request that will be included in release 7.32.0 release-blocker This bug is blocking the next release Run Smoke E2E Triggers smoke e2e on Bitrise team-wallet-framework
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MajorLift @sethkfman