Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add skip label to bypass sonarcloud #11425

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented Sep 25, 2024

Description

Adds logic in the sonar-cloud-quality-gate-status step in the CI that checks for the existence of skip-sonar-cloud label. If it exists, the step is bypassed and passes. If the label doesn't exist, it checks the sonar cloud quality gate status as usual.

Also removes the redundant sonar-cloud dependency in the all-jobs-pass step

Related issues

Fixes:

#11403

Manual testing steps

  • Apply skip-sonar-cloud label

  • Manually re-run ci.yml jobs

  • Notice the sonar-cloud-quality-gate-status step logs that it is skipped and the status checks is green

  • Afterwards, remove skip-sonar-cloud label

  • Manually re-run ci.yml jobs

  • Notice the sonar-cloud-quality-gate-status step runs as usual

Screenshots/Recordings

Before

After

With label applied
https://github.com/MetaMask/metamask-mobile/actions/runs/11026106803/job/30622332596?pr=11425

Without label applied
https://github.com/MetaMask/metamask-mobile/actions/runs/11026106803/job/30623782793

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Cal-L Cal-L requested a review from a team as a code owner September 25, 2024 04:06
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Cal-L Cal-L added skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. team-mobile-platform needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) No QA Needed Apply this label when your PR does not need any QA effort. and removed team-mobile-platform skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. labels Sep 25, 2024
@Cal-L Cal-L added the skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. label Sep 25, 2024
Copy link

Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cal-L Cal-L added this pull request to the merge queue Sep 25, 2024
Merged via the queue into main with commit f2b4392 Sep 25, 2024
41 checks passed
@Cal-L Cal-L deleted the ci/sonar-cloud-qg-bypass branch September 25, 2024 14:58
@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 25, 2024
@metamaskbot metamaskbot added the release-7.33.0 Issue or pull request that will be included in release 7.33.0 label Sep 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.33.0 Issue or pull request that will be included in release 7.33.0 skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants