chore: Add skip label to bypass sonarcloud #11425
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds logic in the
sonar-cloud-quality-gate-status
step in the CI that checks for the existence ofskip-sonar-cloud
label. If it exists, the step is bypassed and passes. If the label doesn't exist, it checks the sonar cloud quality gate status as usual.Also removes the redundant
sonar-cloud
dependency in theall-jobs-pass
stepRelated issues
Fixes:
#11403
Manual testing steps
Apply
skip-sonar-cloud
labelManually re-run
ci.yml
jobsNotice the
sonar-cloud-quality-gate-status
step logs that it is skipped and the status checks is greenAfterwards, remove
skip-sonar-cloud
labelManually re-run
ci.yml
jobsNotice the
sonar-cloud-quality-gate-status
step runs as usualScreenshots/Recordings
Before
After
With label applied
https://github.com/MetaMask/metamask-mobile/actions/runs/11026106803/job/30622332596?pr=11425
Without label applied
https://github.com/MetaMask/metamask-mobile/actions/runs/11026106803/job/30623782793
Pre-merge author checklist
Pre-merge reviewer checklist