-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ramp): use list item from the components library #11421
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
I have read the CLA Document and I hereby sign the CLA |
…to feat/refactor-ramps-component-library
…to feat/refactor-ramps-component-library
…to feat/refactor-ramps-component-library
…to feat/refactor-ramps-component-library
…to feat/refactor-ramps-component-library
Bitrise✅✅✅ Commit hash: a4b3d1c Note
|
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, congratulations on your first mobile PR to be merged 👏
Description
Previously, we used a custom ListItem component. With these changes, we now use the ListItem from the component library to ensure consistency in the app's appearance.
Related issues
Manual testing steps
There’s no specific steps to review this feature, as it affects the overall look of all the Ramp features. However, there are a few pages that differ more from their previous appearance, as they now use the proper styling. Please check the attached screenshots below
Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist