Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ramp): use list item from the components library #11421

Merged
merged 48 commits into from
Oct 8, 2024

Conversation

AxelGes
Copy link
Contributor

@AxelGes AxelGes commented Sep 24, 2024

Description

Previously, we used a custom ListItem component. With these changes, we now use the ListItem from the component library to ensure consistency in the app's appearance.

Related issues

Manual testing steps

There’s no specific steps to review this feature, as it affects the overall look of all the Ramp features. However, there are a few pages that differ more from their previous appearance, as they now use the proper styling. Please check the attached screenshots below

Screenshots/Recordings

Before After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Sep 24, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@AxelGes
Copy link
Contributor Author

AxelGes commented Sep 24, 2024

I have read the CLA Document and I hereby sign the CLA

@wachunei wachunei changed the title Feat: refactor ramps component library refactor(ramp): use list item from the components library Sep 24, 2024
wachunei
wachunei previously approved these changes Oct 7, 2024
…to feat/refactor-ramps-component-library
@AxelGes AxelGes added the team-ramp issues related to Ramp features label Oct 7, 2024
…to feat/refactor-ramps-component-library
@AxelGes AxelGes marked this pull request as ready for review October 7, 2024 20:46
@AxelGes AxelGes requested review from a team as code owners October 7, 2024 20:46
@wachunei wachunei added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 7, 2024
@AxelGes AxelGes added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 7, 2024
Copy link
Contributor

github-actions bot commented Oct 7, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: a4b3d1c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/bf6d201c-c932-43f1-b230-4caa7e1f7ae7

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarqubecloud bot commented Oct 7, 2024

Copy link
Member

@wachunei wachunei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, congratulations on your first mobile PR to be merged 👏

@wachunei wachunei added this pull request to the merge queue Oct 8, 2024
@wachunei wachunei removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 8, 2024
Merged via the queue into main with commit 5b1d54a Oct 8, 2024
46 of 48 checks passed
@wachunei wachunei deleted the feat/refactor-ramps-component-library branch October 8, 2024 15:01
@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.34.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-ramp issues related to Ramp features
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants