Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replace decomissioned cloudflare-ipfs.com with gateway.pinata.cloud #11401

Merged
merged 1 commit into from
Oct 4, 2024
Merged

fix: replace decomissioned cloudflare-ipfs.com with gateway.pinata.cloud #11401

merged 1 commit into from
Oct 4, 2024

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Sep 23, 2024 •
edited
Loading

Description

The default IPFS gateway cloudflare-ipfs.com was decomissioned on August 14 2024.

https://blog.cloudflare.com/cloudflares-public-ipfs-gateways-and-supporting-interplanetary-shipyard/

  • Change default IPFS gateway from cloudflare-ipfs.com to gateway.pinata.cloud
  • Remove cloudflare-ipfs.com from IPFS gateways

Related issues

Manual testing steps

  1. Set up wallet on previous version, keeping default IPFS gateway
  2. Observe IPFS gateway requests failing
  3. Upgrade metamask-mobile with this patch
  4. Observe IPFS gateway requests succeeding

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@legobeat legobeat added team-security Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 23, 2024
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@legobeat legobeat marked this pull request as ready for review September 23, 2024 23:02
@legobeat legobeat requested review from a team as code owners September 23, 2024 23:02
@legobeat legobeat force-pushed the remove-offline-ipfs-gateway branch from 194bf44 to 85dfc82 Compare September 24, 2024 01:32
@legobeat legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 24, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 85dfc82
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4417ec22-e770-4a9f-bd27-52a907f8d440

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

vinnyhoward
vinnyhoward previously approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@vinnyhoward vinnyhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None blocking but it might be good to put the default IPFS gateway url in a env so its easier to update next time? But then again, this change is so infrequent so it probably doesn't matter that much.
LGTM✅

@legobeat legobeat enabled auto-merge September 24, 2024 01:52
@legobeat legobeat force-pushed the remove-offline-ipfs-gateway branch 2 times, most recently from 7362620 to 865956b Compare September 25, 2024 18:51
@legobeat legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 25, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 865956b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f573e40f-c120-46e3-b03e-777ba4fd5ad6

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@legobeat legobeat requested a review from a team September 25, 2024 20:10
@legobeat legobeat force-pushed the remove-offline-ipfs-gateway branch from 865956b to c1cc267 Compare September 26, 2024 00:36
@legobeat legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 26, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: d9c7753
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ecf047c2-9dd7-4f73-baf4-e95126087737

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@legobeat legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 27, 2024
@legobeat legobeat force-pushed the remove-offline-ipfs-gateway branch from d9c7753 to c67f9d7 Compare September 29, 2024 22:00
@legobeat legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 30, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: c67f9d7
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b034aa66-908d-4054-a748-25d01fee44c6

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@legobeat legobeat force-pushed the remove-offline-ipfs-gateway branch 2 times, most recently from 28ec0e8 to aa40bff Compare October 2, 2024 19:30
NicolasMassart
NicolasMassart approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, expecting the issue about possible migration to be created and linked in this PR to make sure it's going to be tracked.

@legobeat legobeat requested a review from a team as a code owner October 3, 2024 09:52
@legobeat legobeat force-pushed the remove-offline-ipfs-gateway branch from f19adef to a2d2a9e Compare October 3, 2024 18:01
@legobeat
Copy link
Contributor Author

legobeat commented Oct 3, 2024

@MetaMask/wallet-ux ping

@legobeat legobeat force-pushed the remove-offline-ipfs-gateway branch from b70159f to 73b062f Compare October 4, 2024 00:32
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@legobeat legobeat added this pull request to the merge queue Oct 4, 2024
Merged via the queue into main with commit ac79785 Oct 4, 2024
36 of 37 checks passed
@legobeat legobeat deleted the remove-offline-ipfs-gateway branch October 4, 2024 00:58
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2024
@NicolasMassart
Copy link
Contributor

Looks good to me, expecting the issue about possible migration to be created and linked in this PR to make sure it's going to be tracked.

Where's the followup issue?

@NicolasMassart
Copy link
Contributor

Using #11692 as a follow up for state migration

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vinnyhoward vinnyhoward vinnyhoward approved these changes

@NicolasMassart NicolasMassart NicolasMassart approved these changes

@EtherWizard33 EtherWizard33 Awaiting requested review from EtherWizard33

@NicholasEllul NicholasEllul Awaiting requested review from NicholasEllul

@andreahaku andreahaku Awaiting requested review from andreahaku

@darkwing darkwing Awaiting requested review from darkwing

Assignees
No one assigned
Labels
release-7.34.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-lavamoat team-security team-wallet-ux
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@legobeat @NicolasMassart @vinnyhoward @gauthierpetetin