Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add learn more modal component for staking #11399

Merged
merged 22 commits into from
Sep 26, 2024
Merged

feat: add learn more modal component for staking #11399

merged 22 commits into from
Sep 26, 2024

Conversation

amitabh94
Copy link
Contributor

@amitabh94 amitabh94 commented Sep 23, 2024 •
edited
Loading

Description

This PR adds a new 'Learn More' Modal component that can be activated from the main input screen of mobile staking.
This is a basic component that opens up as a bottom sheet and has buttons to navigate to FAQ's for pooled staking and to close the modal .

This PR also updates the navigation routes for staking to differentiate between screens and modals and consolidates them into a new routes file for staking .

Related issues

Closes STAKE-825

Manual testing steps

  1. Go to the Stake Page
  2. Click on the Learn more Icon on the rate card
  3. Learn more modal should open up

Screenshots/Recordings

Before

Learn.More.Icon._Before.mp4

After

Learn.More.Modal.mp4

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@amitabh94
feat: add LearnMoreTooltip component for pooled staking
239595b
@amitabh94
refactor: improve stake navigation to include screens and modals
04a4052
@amitabh94
feat: add buttons and text to stake tooltip component
4f6a4a1 
This commit adds image,text and buttons to the tooltip component. It also updates the language strings in the en.json file to include new phrases related to this tooltip.
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@amitabh94 amitabh94 changed the title feat: add Learmore tooltip component for staking feat: add learn more tooltip component for staking Sep 23, 2024
@amitabh94 amitabh94 changed the title feat: add learn more tooltip component for staking feat: add learn more modal component for staking Sep 23, 2024
@amitabh94 amitabh94 added team-stake Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 23, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: ee8b542
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/585c127e-0b55-445a-925b-b2db32ba86ca

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@amitabh94 amitabh94 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 23, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 7098654
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f162e527-412e-437b-95fa-bf0749b90aac

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@amitabh94 amitabh94 marked this pull request as ready for review September 23, 2024 23:23
@amitabh94 amitabh94 requested review from a team as code owners September 23, 2024 23:23
@amitabh94 amitabh94 enabled auto-merge September 23, 2024 23:23
Matt561
Matt561 previously approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@Matt561 Matt561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very Clean!

Left a question and a comment but otherwise LGTM! 💯

app/components/UI/Stake/components/LearnMoreModal.tsx Outdated Show resolved Hide resolved
app/components/UI/Stake/routes/index.tsx Outdated Show resolved Hide resolved
@amitabh94 amitabh94 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 24, 2024
@Matt561 Matt561 self-requested a review September 24, 2024 17:09
Matt561
Matt561 previously approved these changes Sep 24, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 24, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 2c64efc
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/36ceb265-bca2-48d3-b7bc-1ed5ab7ad547

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@amitabh94 amitabh94 added the Run Smoke E2E Triggers smoke e2e on Bitrise label Sep 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 25, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 3f33738
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8b6548fe-511f-427f-8252-b5f49f6eea9f

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

NicolasMassart
NicolasMassart previously approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@amitabh94 amitabh94 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 71f2e4c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ba53df84-77d3-4df3-bdaa-cdcc523ce62f

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

NicolasMassart
NicolasMassart previously approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Matt561 Matt561 self-requested a review September 26, 2024 16:23
Matt561
Matt561 previously approved these changes Sep 26, 2024
View reviewed changes
@amitabh94 amitabh94 dismissed stale reviews from Matt561 and NicolasMassart via 32df793 September 26, 2024 16:27
@amitabh94 amitabh94 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 26, 2024
@Matt561 Matt561 self-requested a review September 26, 2024 16:34
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 26, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 32df793
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7c5dc695-1ffb-453e-a7fb-7c0818b55469

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
84.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@amitabh94 amitabh94 added this pull request to the merge queue Sep 26, 2024
Merged via the queue into main with commit e68b2a5 Sep 26, 2024
48 checks passed
@amitabh94 amitabh94 deleted the STAKE-825--fe-build-learn-more-tooltip branch September 26, 2024 17:30
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2024
@metamaskbot metamaskbot added the release-7.33.0 Issue or pull request that will be included in release 7.33.0 label Sep 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Matt561 Matt561 Matt561 approved these changes

@NicolasMassart NicolasMassart NicolasMassart approved these changes

Assignees
No one assigned
Labels
release-7.33.0 Issue or pull request that will be included in release 7.33.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-stake
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amitabh94 @NicolasMassart @Matt561 @metamaskbot