Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename the feature flag since it had a typo #11379

Merged

Conversation

EtherWizard33
Copy link
Contributor

@EtherWizard33 EtherWizard33 commented Sep 23, 2024

Description

This PR just renames the feature flag since it had a typo, making it difficult to find for someone looking for multichain since mu-l-ti had a typo.

Related issues

Fixes:

Manual testing steps

  1. To test without the mutlichain mocked screens, in js.env toggle the feature flag off (the default is also off) by setting export MM_MULTICHAIN_V1_ENABLED=""
  2. Then connect to a dapp via the in-app browser and see the current screens currently used in prod
  3. To enable mulitichain mocked screens, set the export MM_MULTICHAIN_V1_ENABLED="1" and connect to a dapp to see new mocked multichain screens

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@EtherWizard33 EtherWizard33 added Run Smoke E2E Triggers smoke e2e on Bitrise team-wallet-ux labels Sep 23, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@EtherWizard33 EtherWizard33 marked this pull request as ready for review September 23, 2024 16:28
@EtherWizard33 EtherWizard33 requested a review from a team as a code owner September 23, 2024 16:28
Copy link
Contributor

github-actions bot commented Sep 23, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: ff083ea
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/52d48109-90b7-405c-a309-8f965f209c41

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link

@EtherWizard33 EtherWizard33 added this pull request to the merge queue Sep 24, 2024
Merged via the queue into main with commit eaa9805 Sep 24, 2024
36 checks passed
@EtherWizard33 EtherWizard33 deleted the refactor-2794-just-rename-the-feature-flag-it-had-a-typo branch September 24, 2024 14:31
@github-actions github-actions bot locked and limited conversation to collaborators Sep 24, 2024
@metamaskbot metamaskbot added the release-7.33.0 Issue or pull request that will be included in release 7.33.0 label Sep 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.33.0 Issue or pull request that will be included in release 7.33.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants