Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): Bump @metamask/keyring-controller from ^16.1.0 to ^17.2.1 #11351

Merged
merged 2 commits into from
Sep 20, 2024
Merged

chore(deps): Bump @metamask/keyring-controller from ^16.1.0 to ^17.2.1 #11351

merged 2 commits into from
Sep 20, 2024

Conversation

MajorLift
Copy link
Contributor

@MajorLift MajorLift commented Sep 20, 2024 •
edited
Loading

Description

### Changed

- **BREAKING:** Bump `@metamask/keyring-controller` from `^16.1.0` to `^17.2.1` ([#11351](https://github.com/MetaMask/metamask-mobile/pull/11351))

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security Socket Security
Copy link

socket-security bot commented Sep 20, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/keyring-controller@17.2.1 None 0 537 kB metamaskbot

🚮 Removed packages: npm/@metamask/keyring-controller@16.1.0

View full report↗︎

@MajorLift MajorLift self-assigned this Sep 20, 2024
@MajorLift MajorLift changed the title Bump @metamask/keyring-controller from ^16.1.0 to ^17.2.1 chore(deps): Bump @metamask/keyring-controller from ^16.1.0 to ^17.2.1 Sep 20, 2024
@MajorLift MajorLift force-pushed the jongsun/chore/bump/keyring-controller-17.2.0 branch from 75ade99 to a0ae348 Compare September 20, 2024 18:11
@MajorLift MajorLift added the Run Smoke E2E Triggers smoke e2e on Bitrise label Sep 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 20, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: d524757
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/448a8163-5ed9-4212-b39e-7b4face067f7

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@MajorLift MajorLift mentioned this pull request Sep 20, 2024
Merged
7 tasks
@MajorLift MajorLift added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 20, 2024
@MajorLift MajorLift requested review from a team September 20, 2024 19:16
@MajorLift MajorLift marked this pull request as ready for review September 20, 2024 19:30
@MajorLift MajorLift requested review from a team as code owners September 20, 2024 19:30
@MajorLift MajorLift enabled auto-merge September 20, 2024 19:30
sethkfman
sethkfman approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MajorLift MajorLift added this pull request to the merge queue Sep 20, 2024
Merged via the queue into main with commit 4a79d41 Sep 20, 2024
53 checks passed
@MajorLift MajorLift deleted the jongsun/chore/bump/keyring-controller-17.2.0 branch September 20, 2024 20:01
@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2024
@metamaskbot metamaskbot added the release-7.33.0 Issue or pull request that will be included in release 7.33.0 label Sep 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Prithpal-Sooriya Prithpal-Sooriya Prithpal-Sooriya approved these changes

@sethkfman sethkfman sethkfman approved these changes

Assignees

@MajorLift MajorLift

Labels
release-7.33.0 Issue or pull request that will be included in release 7.33.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-wallet-framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KeyringController upgrade from v16 to v17
4 participants
@MajorLift @sethkfman @Prithpal-Sooriya @metamaskbot