-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: replace Segment patch by plugin #11350
Conversation
remove patch
with expected type issue
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Bitrise✅✅✅ Commit hash: d808284 Note
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Bitrise❌❌❌ Commit hash: d2ddcdc Note
Tip
|
Quality Gate passedIssues Measures |
Description
Replace the Segment SDK patch that was updating events for anonymous user id by a plugin that does the same
Important
This PR doesn't change the behaviour of the metrics system.
It only allows to get rid of the patch.
Related issues
Fixes #11219
May also fix #11065
Manual testing steps
Screenshots/Recordings
Before
Same as after, no functional change
After
The non anonymous part of the event (no properties, but userId)
The anonymous part of the event (properties, but userId replaced by anonymous id)
Pre-merge author checklist
Pre-merge reviewer checklist