chore(js-ts): Convert app/components/UI/BlockingActionModal/index.js to TypeScript #11308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
devin-ai-integration
bot
added
needs-dev-review
|
sethkfman
added
team-ai
github-actions bot
pushed a commit
that referenced
this pull request
Sep 23, 2024
…to TypeScript (#11308) # Convert app/components/UI/BlockingActionModal/index.js to TypeScript ## Changes Made - Renamed `index.js` to `index.tsx` - Removed `PropTypes` import and prop type definitions - Defined `BlockingActionModalProps` interface for component props - Added type annotations for function parameters and variables - Imported `Theme` type from '../../../util/theme/models' - Added type for `colors` parameter in `createStyles` function - Made `onAnimationCompleted` prop optional to maintain compatibility - Reverted changes to `ConnectQRHardware/index.tsx` ## Motivation This change is part of our ongoing effort to migrate the codebase to TypeScript, improving type safety and developer experience. ## Context The BlockingActionModal component is used in various parts of the application to display a modal with a loading spinner. Converting it to TypeScript will help catch potential type-related errors and improve code maintainability. ## Related Issues N/A ## Manual Testing Steps 1. Verify that the BlockingActionModal component still functions correctly in all places it's used. 2. Check that the loading spinner appears when `isLoadingAction` is true. 3. Ensure that the modal shows and hides properly based on the `modalVisible` prop. ## Notes - The `onAnimationCompleted` prop was made optional to avoid unnecessary modifications to other files using this component. - No changes were required in the component's logic or styling. - Changes to `ConnectQRHardware/index.tsx` have been reverted to ensure this PR only contains intended changes related to the BlockingActionModal component. - The scope of this PR is limited to the TypeScript conversion of BlockingActionModal. [This Devin run](https://preview.devin.ai/devin/37804c3c59094f18b33f6e10a3ab07e5) was requested by Sampriti --------- Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
github-actions
bot
removed
the
needs-dev-review
metamaskbot
added
the
release-7.33.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert app/components/UI/BlockingActionModal/index.js to TypeScript
Changes Made
index.jstoindex.tsxPropTypesimport and prop type definitionsBlockingActionModalPropsinterface for component propsThemetype from '../../../util/theme/models'colorsparameter increateStylesfunctiononAnimationCompletedprop optional to maintain compatibilityConnectQRHardware/index.tsxMotivation
This change is part of our ongoing effort to migrate the codebase to TypeScript, improving type safety and developer experience.
Context
The BlockingActionModal component is used in various parts of the application to display a modal with a loading spinner. Converting it to TypeScript will help catch potential type-related errors and improve code maintainability.
Related Issues
N/A
Manual Testing Steps
isLoadingActionis true.modalVisibleprop.Notes
onAnimationCompletedprop was made optional to avoid unnecessary modifications to other files using this component.ConnectQRHardware/index.tsxhave been reverted to ensure this PR only contains intended changes related to the BlockingActionModal component.This Devin run was requested by Sampriti