Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(js-ts): Convert app/components/Base/SelectorButton.js to TypeScript #11303

Merged
merged 5 commits into from
Sep 23, 2024

Conversation

devin-ai-integration[bot]
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Sep 18, 2024

This PR converts the SelectorButton component to TypeScript, ensuring type safety and consistency with the rest of the codebase.

Changes made:

  • Renamed SelectorButton.js to SelectorButton.tsx
  • Defined types for component props
  • Removed PropTypes in favor of TypeScript types
  • Updated imports to include necessary types
  • Ensured compatibility with existing functionality

This Devin run was requested by Moritz.

If you have any feedback, you can leave comments in the PR and I'll address them in the app!

@devin-ai-integration devin-ai-integration bot requested a review from a team as a code owner September 18, 2024 20:25
@devin-ai-integration devin-ai-integration bot added No QA Needed Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform labels Sep 18, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cal-L Cal-L added the team-ai AI team (for the Devin AI bot) label Sep 23, 2024
@Cal-L Cal-L added this pull request to the merge queue Sep 23, 2024
Merged via the queue into main with commit 7daee9d Sep 23, 2024
39 checks passed
@Cal-L Cal-L deleted the convert-ts-SelectorButton branch September 23, 2024 20:40
@github-actions github-actions bot locked and limited conversation to collaborators Sep 23, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 23, 2024
@metamaskbot metamaskbot added the release-7.33.0 Issue or pull request that will be included in release 7.33.0 label Sep 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.33.0 Issue or pull request that will be included in release 7.33.0 team-ai AI team (for the Devin AI bot) team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants