-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added KeyValueRow to component-library/components-temp #11294
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Bitrise❌❌❌ Commit hash: 3a353a3 Note
Tip
|
3a353a3
to
1761159
Compare
333d4e7
to
be40200
Compare
Bitrise❌❌❌ Commit hash: 7b8036c Note
Tip
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you provide a Figma link in the comment?
Bitrise❌❌❌ Commit hash: 120b2b4 Note
Tip
|
Sure thing! Here's what I used. I don't think it's part of DS yet though. |
Bitrise❌❌❌ Commit hash: da9d4f4 Note
Tip
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11294 +/- ##
==========================================
+ Coverage 55.84% 55.95% +0.10%
==========================================
Files 1594 1607 +13
Lines 37855 37974 +119
Branches 4545 4597 +52
==========================================
+ Hits 21142 21250 +108
- Misses 16214 16218 +4
- Partials 499 506 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Bitrise❌❌❌ Commit hash: a5f3f07 Note
Tip
|
Bitrise✅✅✅ Commit hash: ad5f60f Note
|
Quality Gate passedIssues Measures |
Description
This PR adds
<KeyValueRow />
to thecomponents-temp
library. The motivation is to improve DX and reusability since we commonly display a variety of key/value pairs within the app.What's Included?
1.
<KeyValueRow />
2.
KeyValueRowStubs
<Root />
: The main container. Itschildren
should be two<Section />
components representing the left side (key) and right side (value) of the pairing.<Section />
: A container representing either the key or the value.<Label />
: A convenience component that provides built-in support for icons, tooltips, and formatting.3. Updated
withNavigation
Storybook DecoratorThis change was made to support the tooltip modal used within the
<KeyValueRow />
. I think it's appropriate for the story to accurately reflect the interactivity of the components on display.This should also allow others to use modals in their stories.
These stubs can be used to extend this and create new variants of the KeyValueRow.
Related issues
STAKE-829: [FE] Create Key Value Row component - link
Manual testing steps
KeyValueRow
story inside of "Components Temp" folder.<KeyValueRow />
found within the storyScreenshots/Recordings
Before
N/A this is a net new change.
After
Design Link
https://www.figma.com/design/1c0Y9jDJe6p0j82jydJDcs/Mobile-Staking?node-id=2187-96037&t=kOEnlk3CXZ727Qjb-1
Storybook Health Check
Storybook is still working after making the
withNavigation
decorator changesstake-829-storybook-health-check.mov
Pre-merge author checklist
Pre-merge reviewer checklist