chore(js-ts): Convert app/components/UI/GenericButton/index.android.js to TypeScript #11280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
…nal, accept GestureResponderEvent, and remove DEVIN_TODO
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
metamaskbot
added
the
release-7.33.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description: Convert GenericButton component to TypeScript
Summary
This PR converts the
GenericButtoncomponent from JavaScript to TypeScript. The component is located inapp/components/UI/GenericButton/index.android.tsx.Changes
GenericButtonProps)childrenandonPressprops optionalonPresstype to acceptGestureResponderEventReact.FCtype for the componentDetails
GenericButtoncomponent is now fully typed, improving type safety and developer experienceindex.test.tsx) was updated to include a mockonPressfunction and children prop in the shallow render testNotes
Buttoncomponent from the component libraryTesting
Related Issues
ButtoncomponentPlease review the changes and let me know if any further modifications are needed.
Link to Devin run: https://preview.devin.ai/devin/67b8e6becb3f4524a620748e85cb5131
Requested by: Silas
If you have any feedback, you can leave comments in the PR and I'll address them in the app!