-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(js-ts): Convert app/components/UI/ConnectHeader/index.js to TypeScript #11274
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pull Request: Convert app/components/UI/ConnectHeader/index.js to TypeScript
Description
This PR converts the ConnectHeader component from JavaScript to TypeScript as part of our ongoing effort to improve type safety and maintainability in the MetaMask Mobile codebase.
Changes Made
app/components/UI/ConnectHeader/index.js
to TypeScript (renamed toindex.tsx
)Key Implementation Details
app/util/theme/models
for proper typing of the createStyles functionVerification Steps
yarn tsc
to check for TypeScript errors (passed)yarn lint
to check for linting issues (passed with some warnings in other files)Related Issues
N/A
Additional Notes
This PR is part of the ongoing JavaScript to TypeScript conversion effort. It improves type safety and maintainability of the ConnectHeader component without changing its functionality.
Devin Run Information
If you have any feedback, you can leave comments in the PR and I'll address them in the app!