chore(js-ts): Convert app/components/UI/OnboardingScreenWithBg/index.js to TypeScript #11273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Cal-L
reviewed
Sep 19, 2024
app/components/Views/GasEducationCarousel/__snapshots__/index.test.tsx.snap
Show resolved
Hide resolved
|
github-actions bot
pushed a commit
that referenced
this pull request
Sep 23, 2024
…js to TypeScript (#11273) Title: chore(js-ts): Convert app/components/UI/OnboardingScreenWithBg/index.js to TypeScript Description: This PR converts the OnboardingScreenWithBg component from JavaScript to TypeScript. The following changes have been made: 1. Renamed `index.js` to `index.tsx`. 2. Removed `PropTypes` and implemented TypeScript interfaces and types. 3. Updated imports to include necessary types. 4. Added type annotations to function parameters and variables. 5. Created custom types for `ImageKeys` and `ImagesType`. 6. Updated the component to use the new TypeScript types and interfaces. 7. Removed the `propTypes` object and added JSDoc comments to the interface. 8. Implemented null checks for the `backgroundImage`. Key changes: - Converted `colors` parameter type in `createStyles` function to `ThemeColors`. - Created `OnboardingScreenWithBgProps` interface for component props. - Updated `images` object type to `ImagesType`. - Added type safety for the `screen` prop using `ImageKeys` type. Checklist: - [x] Converted JS file to TS - [x] Updated types and added necessary imports - [x] Ensured `yarn tsc` passes without errors - [x] Ensured `yarn lint` passes without errors (warnings ignored as per criteria) - [x] Added comments from old `propTypes` to the new interface Link to Devin run: https://preview.devin.ai/devin/338aa8109dd94cdcac49824ec6878b80 This Devin run was requested by Sampriti. Please review the changes and let me know if any further modifications are needed. If you have any feedback, you can leave comments in the PR and I'll address them in the app! --------- Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
metamaskbot
added
the
release-7.33.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title: chore(js-ts): Convert app/components/UI/OnboardingScreenWithBg/index.js to TypeScript
Description:
This PR converts the OnboardingScreenWithBg component from JavaScript to TypeScript. The following changes have been made:
index.jstoindex.tsx.PropTypesand implemented TypeScript interfaces and types.ImageKeysandImagesType.propTypesobject and added JSDoc comments to the interface.backgroundImage.Key changes:
colorsparameter type increateStylesfunction toThemeColors.OnboardingScreenWithBgPropsinterface for component props.imagesobject type toImagesType.screenprop usingImageKeystype.Checklist:
yarn tscpasses without errorsyarn lintpasses without errors (warnings ignored as per criteria)propTypesto the new interfaceLink to Devin run: https://preview.devin.ai/devin/338aa8109dd94cdcac49824ec6878b80
This Devin run was requested by Sampriti.
Please review the changes and let me know if any further modifications are needed.
If you have any feedback, you can leave comments in the PR and I'll address them in the app!