-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(js-ts): Convert app/components/Base/ModalDragger.js to TypeScript #11272
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR converts the
ModalDragger
component from JavaScript to TypeScript, ensuring proper typing and adherence to TypeScript best practices.Changes made
ModalDragger.js
toModalDragger.tsx
Theme
type from the theme modelsuseTheme
hook usage with proper typingModalDragger.js
fileRelated Issues
N/A
Manual Testing Steps
ModalDragger
componentChecklist
chore(js-ts): Convert app/components/Base/ModalDragger.js to TypeScript
This Devin run was requested by Jeffrey.
If you have any feedback, you can leave comments in the PR and I'll address them in the app!