Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(js-ts): Convert app/components/Base/ModalDragger.js to TypeScript #11272

Merged
merged 4 commits into from
Sep 23, 2024

Conversation

devin-ai-integration[bot]
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Sep 18, 2024

Description

This PR converts the ModalDragger component from JavaScript to TypeScript, ensuring proper typing and adherence to TypeScript best practices.

Changes made

  • Renamed ModalDragger.js to ModalDragger.tsx
  • Added TypeScript types for props and function parameters
  • Removed PropTypes and replaced with TypeScript interface
  • Imported and used the Theme type from the theme models
  • Updated the useTheme hook usage with proper typing
  • Removed the obsolete ModalDragger.js file

Related Issues

N/A

Manual Testing Steps

  1. Build and run the app
  2. Navigate to screens that use the ModalDragger component
  3. Verify that the component renders and functions correctly

Checklist

  • The PR title follows the convention: chore(js-ts): Convert app/components/Base/ModalDragger.js to TypeScript
  • The code follows the project's TypeScript coding standards
  • All TypeScript errors and warnings have been resolved
  • The changes have been tested locally

This Devin run was requested by Jeffrey.

If you have any feedback, you can leave comments in the PR and I'll address them in the app!

@devin-ai-integration devin-ai-integration bot requested a review from a team as a code owner September 18, 2024 07:56
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment

app/components/Base/ModalDragger.tsx Outdated Show resolved Hide resolved
app/components/Base/ModalDragger.tsx Outdated Show resolved Hide resolved
Copy link

Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cal-L Cal-L added this pull request to the merge queue Sep 23, 2024
@Cal-L Cal-L removed this pull request from the merge queue due to a manual request Sep 23, 2024
@Cal-L Cal-L added the team-ai AI team (for the Devin AI bot) label Sep 23, 2024
@Cal-L Cal-L added this pull request to the merge queue Sep 23, 2024
Merged via the queue into main with commit 4d01d8a Sep 23, 2024
37 of 39 checks passed
@Cal-L Cal-L deleted the convert-ts-ModalDragger-490 branch September 23, 2024 20:25
@github-actions github-actions bot locked and limited conversation to collaborators Sep 23, 2024
@metamaskbot metamaskbot added the release-7.33.0 Issue or pull request that will be included in release 7.33.0 label Sep 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.33.0 Issue or pull request that will be included in release 7.33.0 team-ai AI team (for the Devin AI bot)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants