Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(js-ts): Convert app/components/UI/ComponentErrorBoundary/index.js to TypeScript #11271

Merged
merged 3 commits into from
Sep 23, 2024
Merged

chore(js-ts): Convert app/components/UI/ComponentErrorBoundary/index.js to TypeScript #11271

merged 3 commits into from
Sep 23, 2024

Conversation

devin-ai-integration[bot]
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Sep 18, 2024 •
edited
Loading

Convert ComponentErrorBoundary to TypeScript

This PR converts app/components/UI/ComponentErrorBoundary/index.js to TypeScript.

Changes

  • Converted app/components/UI/ComponentErrorBoundary/index.js to TypeScript.
  • Renamed the file to index.tsx.
  • Defined proper TypeScript interfaces for props and state.
  • Removed PropTypes and replaced with TypeScript types.
  • Removed DEVIN_TODOs and eslint-disable comment.
  • Ensured all methods and properties are properly typed.

Additional Information

Testing

  • Ran yarn tsc to ensure no TypeScript errors.
  • Ran yarn lint to check for linting issues (no errors related to our changes).

Please review the changes and let me know if any further modifications are needed.

If you have any feedback, you can leave comments in the PR and I'll address them in the app!

@devin-ai-integration devin-ai-integration bot requested a review from a team as a code owner September 18, 2024 07:48
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Cal-L
Cal-L approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cal-L Cal-L added team-ai AI team (for the Devin AI bot) No QA Needed Apply this label when your PR does not need any QA effort. labels Sep 23, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Cal-L Cal-L added this pull request to the merge queue Sep 23, 2024
Merged via the queue into main with commit 3136025 Sep 23, 2024
46 of 48 checks passed
@Cal-L Cal-L deleted the convert-ts-index-306 branch September 23, 2024 23:49
@github-actions github-actions bot locked and limited conversation to collaborators Sep 23, 2024
@metamaskbot metamaskbot added the release-7.33.0 Issue or pull request that will be included in release 7.33.0 label Sep 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Cal-L Cal-L Cal-L approved these changes

Assignees
No one assigned
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.33.0 Issue or pull request that will be included in release 7.33.0 team-ai AI team (for the Devin AI bot)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cal-L @metamaskbot