Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: STAKE-822 build your balance component #11261

Merged
merged 48 commits into from
Sep 25, 2024
Merged

feat: STAKE-822 build your balance component #11261

merged 48 commits into from
Sep 25, 2024

Conversation

Matt561
Copy link
Contributor

@Matt561 Matt561 commented Sep 17, 2024 •
edited
Loading

Description

Added:

  • "Staked Ethereum" balance row item to the ETH asset page. This PR is using mock data until it is connected to the backend. This component will be hidden via feature flag until it's ready.

Related issues

STAKE-822: [FE] Build "Your Balance" component

Manual testing steps

  1. Enable the feature flag by adding export MM_POOLED_STAKING_UI_ENABLED=true to your local .js.env file
  2. Select Ethereum from the token list
  3. You should see the "Staked Ethereum" balance row item, 2 "unstaking in progress" banners, 1 claim ETH banner, 1 "Unstake", and 1 "Stake more" button.
  4. Clicking the "Stake more" button should open the StakeInputView that was recently added in a previous PR.

Screenshots/Recordings

Before

stake-822-your-balance-before-demo.mov

After

stake-822-your-balance-after-demo.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Matt561 Matt561 force-pushed the feat/stake-822-build-your-balance-component branch from d9c473a to ad091a4 Compare September 19, 2024 14:01
@Matt561 Matt561 added team-stake Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 19, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: af9075c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d27c58e2-a933-4a50-a41f-f5c7fbcfa139

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@Matt561 Matt561 force-pushed the feat/stake-822-build-your-balance-component branch 2 times, most recently from 1c163b4 to 09c9fa5 Compare September 19, 2024 15:52
@Matt561 Matt561 force-pushed the feat/stake-822-build-your-balance-component branch from 09c9fa5 to 8e99a0a Compare September 19, 2024 15:53
@Matt561 Matt561 marked this pull request as ready for review September 19, 2024 15:56
@Matt561 Matt561 requested review from a team as code owners September 19, 2024 15:56
@Matt561 Matt561 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 19, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 6a1a607
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d8c73baa-47a8-435e-9d7b-b438667398b8

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
87.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Matt561 Matt561 force-pushed the feat/stake-822-build-your-balance-component branch from acb4415 to 7bd6857 Compare September 20, 2024 15:24
amitabh94
amitabh94 reviewed Sep 20, 2024
View reviewed changes
Copy link
Contributor

@amitabh94 amitabh94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments but overall LGTM! 👏🏼

app/components/UI/Stake/components/StakingBalance/StakingBalance.test.tsx Outdated Show resolved Hide resolved
app/components/UI/Stake/components/StakingBalance/StakingBalance.tsx Outdated Show resolved Hide resolved
app/components/UI/Stake/components/StakingBalance/StakingBalance.tsx Show resolved Hide resolved
@Matt561 Matt561 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 25, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 2ffffec
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/19787f7d-757b-46a1-b94e-f20caf2972c2

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@Matt561 Matt561 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 25, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: ba6634a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5c68357e-ef48-4546-902a-2cc605f4aa71

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@Matt561 Matt561 requested a review from amitabh94 September 25, 2024 19:54
@Matt561 Matt561 enabled auto-merge September 25, 2024 19:54
@Matt561 Matt561 disabled auto-merge September 25, 2024 20:04
@Matt561 Matt561 requested a review from amitabh94 September 25, 2024 20:13
@Matt561 Matt561 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 25, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: fdcd2b1
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3f92fac3-92c2-417d-9809-a28f93a2e6a6

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
93.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Matt561 Matt561 enabled auto-merge September 25, 2024 20:20
amitabh94
amitabh94 previously approved these changes Sep 25, 2024
View reviewed changes
@Matt561 Matt561 added this pull request to the merge queue Sep 25, 2024
@amitabh94 amitabh94 removed this pull request from the merge queue due to a manual request Sep 25, 2024
@amitabh94 amitabh94 dismissed their stale review September 25, 2024 20:23

Checking changes to component library

@Matt561 Matt561 added this pull request to the merge queue Sep 25, 2024
Merged via the queue into main with commit f725fa6 Sep 25, 2024
41 of 42 checks passed
@Matt561 Matt561 deleted the feat/stake-822-build-your-balance-component branch September 25, 2024 20:42
@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2024
@metamaskbot metamaskbot added the release-7.33.0 Issue or pull request that will be included in release 7.33.0 label Sep 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amitabh94 amitabh94 amitabh94 approved these changes

Assignees
No one assigned
Labels
release-7.33.0 Issue or pull request that will be included in release 7.33.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-stake
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Matt561 @amitabh94 @metamaskbot