fix: push notifications

[Jonathansoufer]

Description

This PR re-enable push notifications (background/foreground) based on notifee approach.

Related issues

Fixes:

NOTIFY-1103

Manual testing steps

1. Install the MetaMask wallet
2. Click on the Bell Icon on the top-right header
   3.Turn On Notifications
3. Trigger any transaction and leave the app.

Expected behaviour: A device push notification should appear on your device.

Screenshots/Recordings

Before

After

Screen.Recording.2024-09-24.at.07.57.41.mov

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[socket-security]

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@notifee/react-native@9.0.2	None	0	886 kB	mikehardy
npm/@react-native-firebase/app@20.5.0	None	0	504 kB	salakar
npm/@react-native-firebase/messaging@20.5.0	None	0	289 kB	salakar

🚮 Removed packages: npm/@notifee/react-native@7.8.2, npm/@react-native-firebase/app@20.1.0, npm/@react-native-firebase/messaging@20.1.0

View full report↗︎

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 5aeff10
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/73ec7fec-9e0b-49e8-86fe-4bc5437b93d1

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: c8a802b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/fcf475e5-5214-447b-a474-6d55d34d6713

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: d762b5e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/fcf4e088-bf04-4709-a493-517f8f1cc8ca

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
59.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[naugtur]

Approving to unblock, but got one concern about duplicated firebase lib

[NicolasMassart]

Nice work!
Some suggestions, questions and comments, but mainly for maintainability, guidelines compliance and readability.
Well done!
Let me know when I can have a second review pass.

[NicolasMassart]

After discussing the comments I put in the PR, I let @Jonathansoufer decide if this is a blocker for this PR or if he can create a new followup PR to handled them.

So I approve it as I know he is currently evaluating this and it has already been reviewed by many others, so it's overall good to go.
@Jonathansoufer please link this PR in your next PR as the issue to be fixed.

I just want to remind that if we release a fix in prod, we have to be very careful about the test part even if the code part seems fine. Without test we are naked in the wild. I don't really feel comfortable being naked in the wild...