chore: Remove eth-sign

[OGPoyraz]

Description

We recently removed eth_sign operations from extension: MetaMask/metamask-extension#24756
This PR aims to remove eth_sign and all related components from mobile. Also updates @metamask/signature-controller@17.0.0.

Notes

• Removes keyring-controller patch (patch branch) because it's already addressed in @metamask/keyring-controller@16.1.0 here .

Related issues

Fixes: N/A

Manual testing steps

1. Go to the [e2e test dapp] in-app browser (https://metamask.github.io/test-dapp/)
2. Connect the wallet
3. Scroll down to the Eth Sign card (https://metamask.github.io/test-dapp/#ethSign)
4. Click Sign
5. You should see Error: The method "eth_sign" does not exist / is not available.

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[socket-security]

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/keyring-controller@16.1.0	None	0	507 kB	metamaskbot
npm/@metamask/message-manager@9.0.0	None	0	272 kB	metamaskbot
npm/@metamask/signature-controller@17.0.0	None	0	221 kB	metamaskbot

🚮 Removed packages: npm/@metamask/keyring-controller@16.0.0, npm/@metamask/message-manager@8.0.2, npm/@metamask/signature-controller@16.0.0

View full report↗︎

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.57%. Comparing base (7475ab4) to head (f6a39d2).
Report is 30 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #11246      +/-   ##
==========================================
+ Coverage   55.24%   55.57%   +0.32%     
==========================================
  Files        1558     1570      +12     
  Lines       37153    37367     +214     
  Branches     4406     4456      +50     
==========================================
+ Hits        20527    20765     +238     
+ Misses      16155    16111      -44     
- Partials      471      491      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sleepytanya]

Bitrise builds https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/cb2f28e4-0ade-47b3-9cff-f9387b3f564d?tab=artifacts

Signatures work as expected (signatures regression passed).

iOS:

ios.mov

Android:

android.mp4

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[NicolasMassart]

You gave my ethsign friction code a quick death, it had no time to suffer, thank you!