chore(js-ts): Convert ModalNavbarTitle to TypeScript #11243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
devin-ai-integration
bot
added
team-mobile-platform
needs-dev-review
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11243 +/- ##
==========================================
+ Coverage 55.24% 55.66% +0.41%
==========================================
Files 1558 1573 +15
Lines 37153 37476 +323
Branches 4406 4472 +66
==========================================
+ Hits 20527 20860 +333
+ Misses 16155 16125 -30
- Partials 471 491 +20 ☔ View full report in Codecov by Sentry. |
devin-ai-integration
bot
changed the title
devin-ai-integration
bot
changed the title
devin-ai-integration
bot
force-pushed
the
convert-ts-ModalNavbarTitle
branch
from
91588e4 to
72ff1ae
Compare
devin-ai-integration
bot
changed the title
|
github-actions
bot
removed
the
needs-dev-review
metamaskbot
added
the
release-7.32.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert ModalNavbarTitle Component to TypeScript
Description
This PR converts the
ModalNavbarTitlecomponent from JavaScript to TypeScript. The conversion improves type safety and maintainability of the component.Changes Made
index.jstoindex.tsxModalNavbarTitlePropsinterfacePropTypesimport and usageFiles Changed
app/components/UI/ModalNavbarTitle/index.tsxTesting
No functional changes were made. The component should behave exactly as before.
Notes
PureComponentdid not require type parametersstylesobject was left as is, as StyleSheet.create() infers typesLabels
Link to Devin run: https://preview.devin.ai/devin/7a9f387f766c470c8ac4f7d06b9a3333
Requested by: Silas
If you have any feedback, you can leave comments in the PR and I'll address them in the app!