Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(2739): permission summary view gets the ability to disconnect all #11239

Conversation

EtherWizard33
Copy link
Contributor

@EtherWizard33 EtherWizard33 commented Sep 16, 2024

Description

The permission summary view gets the ability to diconnect all

Related issues

Contributes to solve issue: https://github.com/MetaMask/MetaMask-planning/issues/2796

Manual testing steps

I have added screenshot below to see how it looks.

  1. The steps to get this modal to show are to have a dapp already connected and click the icon at the top right header
  2. This will open the bottom sheet with the button to disconnect all.

Screenshots/Recordings

Before After
Screenshot 2024-04-18 at 3 56 43 PM Screenshot 2024-04-18 at 3 56 43 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@EtherWizard33 EtherWizard33 added No QA Needed Apply this label when your PR does not need any QA effort. team-wallet-ux labels Sep 16, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@EtherWizard33 EtherWizard33 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed No QA Needed Apply this label when your PR does not need any QA effort. labels Sep 17, 2024
Copy link
Contributor

github-actions bot commented Sep 17, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: a2e54bf
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4aa08683-cdc4-4718-8660-0c933b746caf

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 44.44444% with 20 lines in your changes missing coverage. Please review.

Project coverage is 55.75%. Comparing base (7475ab4) to head (a2e54bf).
Report is 37 commits behind head on main.

Files with missing lines Patch % Lines
...nents/UI/PermissionsSummary/PermissionsSummary.tsx 73.33% 2 Missing and 2 partials ⚠️
...components/Views/AccountConnect/AccountConnect.tsx 20.00% 4 Missing ⚠️
...ultiSelector/AccountConnectMultiSelector.styles.ts 25.00% 3 Missing ⚠️
...ultiSelector/NetworkConnectMultiSelector.styles.ts 25.00% 3 Missing ⚠️
...UI/PermissionsSummary/PermissionsSummary.styles.ts 50.00% 0 Missing and 2 partials ⚠️
...nnectMultiSelector/AccountConnectMultiSelector.tsx 0.00% 2 Missing ⚠️
...nnectMultiSelector/NetworkConnectMultiSelector.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11239      +/-   ##
==========================================
+ Coverage   55.24%   55.75%   +0.50%     
==========================================
  Files        1558     1580      +22     
  Lines       37153    37646     +493     
  Branches     4406     4507     +101     
==========================================
+ Hits        20527    20988     +461     
- Misses      16155    16168      +13     
- Partials      471      490      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EtherWizard33 EtherWizard33 marked this pull request as ready for review September 18, 2024 11:03
@EtherWizard33 EtherWizard33 requested a review from a team as a code owner September 18, 2024 11:03
@EtherWizard33 EtherWizard33 changed the title feat(2739): permission summary view gets the ability to diconnect all feat(2739): permission summary view gets the ability to disconnect all Sep 18, 2024
Copy link

@EtherWizard33 EtherWizard33 added this pull request to the merge queue Sep 20, 2024
Merged via the queue into main with commit 5646b91 Sep 20, 2024
36 checks passed
@EtherWizard33 EtherWizard33 deleted the feat-2793-permission-summary-gets-the-ability-to-diconnect-all branch September 20, 2024 17:07
@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2024
@metamaskbot metamaskbot added the release-7.33.0 Issue or pull request that will be included in release 7.33.0 label Sep 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.33.0 Issue or pull request that will be included in release 7.33.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants