Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: change relavent to relevant (typo fix) #11230

Merged
merged 3 commits into from
Dec 18, 2024
Merged

chore: change relavent to relevant (typo fix) #11230

merged 3 commits into from
Dec 18, 2024
+2 −2

Conversation

coreyjanssen
Copy link
Contributor

There is a typo on line 578 that is being corrected with this change.

Description

This is a fix for a typo on line 578 (relevant was misspelled as relavent). It appears on the MetaMetrics opt in screen. Doesn't seem to be an issue in Extension, Mobile only.

Related issues

Fixes: #11227

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@coreyjanssen
Change relavent to relevant (typo fix)
a10ef84 
There is a typo on line 578 that is being corrected with this change.
@coreyjanssen coreyjanssen requested a review from a team as a code owner September 16, 2024 16:24
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

sethkfman
sethkfman previously approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman sethkfman added No QA Needed Apply this label when your PR does not need any QA effort. team-mobile-platform labels Sep 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale Issues that have not had activity in the last 90 days label Dec 15, 2024
@coreyjanssen coreyjanssen added the area-design Design bug (previously known as papercuts - ask Hilary for more detail) label Dec 17, 2024
@coreyjanssen
Copy link
Contributor Author

@georgewrmarshall @DDDDDanica is this something the pixel police team could help me with?

@github-actions github-actions bot removed the stale Issues that have not had activity in the last 90 days label Dec 17, 2024
@coreyjanssen coreyjanssen added the type-bug Something isn't working label Dec 17, 2024
@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Mobile label Dec 17, 2024
@georgewrmarshall georgewrmarshall changed the title Change relavent to relevant (typo fix) chore: change relavent to relevant (typo fix) Dec 17, 2024
georgewrmarshall
georgewrmarshall previously approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work @coreyjanssen! 👢🐛 🚀

@georgewrmarshall georgewrmarshall removed team-design-system All issues relating to design system in Mobile type-bug Something isn't working No QA Needed Apply this label when your PR does not need any QA effort. team-mobile-platform area-design Design bug (previously known as papercuts - ask Hilary for more detail) labels Dec 17, 2024
@georgewrmarshall georgewrmarshall added No QA Needed Apply this label when your PR does not need any QA effort. No E2E Smoke Needed If the PR does not need E2E smoke test run type-bug Something isn't working area-design Design bug (previously known as papercuts - ask Hilary for more detail) labels Dec 17, 2024
@georgewrmarshall georgewrmarshall dismissed stale reviews from sethkfman and themself via e7f2b93 December 18, 2024 00:19
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@georgewrmarshall georgewrmarshall added this pull request to the merge queue Dec 18, 2024
Merged via the queue into main with commit 9d6908b Dec 18, 2024
36 checks passed
@georgewrmarshall georgewrmarshall deleted the typo-fix-relevant branch December 18, 2024 00:46
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2024
@metamaskbot metamaskbot added the release-7.39.0 Issue or pull request that will be included in release 7.39.0 label Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@georgewrmarshall georgewrmarshall georgewrmarshall approved these changes

@sethkfman sethkfman Awaiting requested review from sethkfman

Assignees
No one assigned
Labels
area-design Design bug (previously known as papercuts - ask Hilary for more detail) No E2E Smoke Needed If the PR does not need E2E smoke test run No QA Needed Apply this label when your PR does not need any QA effort. release-7.39.0 Issue or pull request that will be included in release 7.39.0 team-mobile-platform type-bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Typo on MetaMetrics opt-in screen
4 participants
@coreyjanssen @georgewrmarshall @sethkfman @metamaskbot