Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Appium separate and optimize app launch time measurements #11213

Merged

Conversation

cortisiko
Copy link
Member

@cortisiko cortisiko commented Sep 14, 2024

Description

This PR refactors the app launch times measurement to capture the time each screen appears, improving granularity. Previously, both cold start tests were in a single feature file, making it difficult to isolate specific test sessions in BrowserStack. Now, the two cold start scenarios are split into separate feature files, allowing for easier identification and tracking of individual test sessions in browserstack.

NOTE: The baseline measures were generated based on ten consecutive runs.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

Screenshot 2024-09-16 at 4 20 22 PM

After

Screenshot 2024-09-16 at 4 20 48 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@cortisiko cortisiko linked an issue Sep 14, 2024 that may be closed by this pull request
9 tasks
@cortisiko cortisiko added the No QA Needed Apply this label when your PR does not need any QA effort. label Sep 14, 2024
@cortisiko cortisiko self-assigned this Sep 14, 2024
@cortisiko cortisiko marked this pull request as ready for review September 16, 2024 20:21
@cortisiko cortisiko requested a review from a team as a code owner September 16, 2024 20:21
@cortisiko cortisiko added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 16, 2024
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments

wdio/features/Performance/AppLaunchEndToEnd.feature Outdated Show resolved Hide resolved
wdio/features/Performance/WarmStartPerformance.feature Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.76%. Comparing base (7475ab4) to head (33e0e8c).
Report is 36 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11213      +/-   ##
==========================================
+ Coverage   55.24%   55.76%   +0.51%     
==========================================
  Files        1558     1580      +22     
  Lines       37153    37627     +474     
  Branches     4406     4501      +95     
==========================================
+ Hits        20527    20981     +454     
- Misses      16155    16156       +1     
- Partials      471      490      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@cortisiko cortisiko added this pull request to the merge queue Sep 17, 2024
Merged via the queue into main with commit 95b1a49 Sep 17, 2024
36 checks passed
@cortisiko cortisiko deleted the appium-separate-and-optimize-app-launch-time-measurements branch September 17, 2024 22:38
@github-actions github-actions bot locked and limited conversation to collaborators Sep 17, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 17, 2024
@metamaskbot metamaskbot added the release-7.32.0 Issue or pull request that will be included in release 7.32.0 label Sep 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.32.0 Issue or pull request that will be included in release 7.32.0 team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Appium: Separate and Optimize App Launch Time Measurements
4 participants