feat(NOTIFY-1096): add account syncing #11190

mathieuartu · 2024-09-13T08:30:15Z

Description

This PR adds account syncing to MetaMask.

⚠️ IMPORTANT: For now, account syncing is disabled, and only enabled in E2E context (using process.env.IS_TEST helper).
It is because we want to add more E2E tests before doing the actual release, and the original course of action was to release on extension first.

More E2E tests will be added in a subsequent PR, and finally we'll have a PR to enable account syncing in production.

As part of profile syncing, with this new feature, users will be able to synchronize all of their accounts and accounts' names across all of their devices.

Related issues

Fixes:

NOTIFY-1096

Manual testing steps

Log in with SRP
Activate profile syncing in preferences
Add new accounts and rename others
Using another browser, log in with SRP
Activate profile syncing in preferences
Watch the magic happen!

Pre-merge author checklist

I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-09-13T08:30:30Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

mathieuartu · 2024-09-13T08:30:57Z

I have read the CLA Document and I hereby sign the CLA

socket-security · 2024-09-13T08:35:04Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/base-controller@7.0.2	None	`+2`	1.18 MB	metamaskbot
npm/@metamask/controller-utils@11.4.2	network	`0`	264 kB	metamaskbot
npm/@metamask/eth-snap-keyring@4.3.6	Transitive: network	`+2`	1.38 MB	metamaskbot
npm/@metamask/keyring-controller@17.3.1	Transitive: environment	`+2`	634 kB	metamaskbot
npm/@metamask/message-manager@11.0.1	None	`0`	210 kB	metamaskbot
npm/@metamask/providers@17.2.1	None	`0`	437 kB	danfinlay, gudahtt, kumavis, ...8 more
npm/@metamask/snaps-controllers@9.11.0	None	`0`	1.62 MB	metamaskbot
npm/@metamask/snaps-rpc-methods@11.4.0	None	`0`	1.26 MB	metamaskbot
npm/@metamask/snaps-utils@8.4.0	network	`+1`	1.64 MB	metamaskbot

🚮 Removed packages: npm/@metamask/base-controller@7.0.1, npm/@metamask/controller-utils@11.3.0, npm/@metamask/eth-snap-keyring@4.3.4, npm/@metamask/keyring-controller@17.2.2, npm/@metamask/message-manager@10.1.1, npm/@metamask/providers@17.1.2, npm/@metamask/snaps-controllers@9.8.0, npm/@metamask/snaps-rpc-methods@11.1.1, npm/@metamask/snaps-utils@8.1.1

View full report↗︎

codecov-commenter · 2024-09-13T11:03:40Z

Codecov Report

Attention: Patch coverage is 60.00000% with 10 lines in your changes missing coverage. Please review.

Project coverage is 55.58%. Comparing base (ead35c4) to head (d0ce191).
Report is 51 commits behind head on main.

Files with missing lines	Patch %	Lines
app/actions/notification/helpers/index.ts	16.66%	5 Missing ⚠️
app/util/notifications/hooks/useAccountSyncing.ts	76.92%	2 Missing and 1 partial ⚠️
app/core/Engine.ts	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #11190      +/-   ##
==========================================
+ Coverage   55.35%   55.58%   +0.23%     
==========================================
  Files        1767     1782      +15     
  Lines       39841    40085     +244     
  Branches     4965     4993      +28     
==========================================
+ Hits        22052    22280     +228     
- Misses      16274    16282       +8     
- Partials     1515     1523       +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-09-13T11:19:57Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: b9bb37a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2134006d-61ca-4b88-9604-1c8f52146b4d

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

…nge event

github-actions · 2024-09-13T12:39:32Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 6c9b2ce
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/79653e7d-5260-497f-b2ed-3cdcf84785e9

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions · 2024-09-13T15:49:15Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: ab17435
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/362ae0c7-a89a-402c-956b-3c7737d8a7c0

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions · 2024-10-31T19:11:58Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 9456194
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/adaa7597-35cc-493c-8e62-ec7e48b0eec0

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions · 2024-10-31T19:13:49Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 89cc06b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1b8820f3-a128-4f26-8247-5b9e2499d47d

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions · 2024-10-31T21:35:46Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 5035497
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ea43794d-6fce-42ef-a589-7d43d947d686

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions · 2024-10-31T22:06:35Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: d0ce191
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1b27f795-c581-417c-bb2c-33cd4ade2081

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

sonarqubecloud · 2024-10-31T22:17:51Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
65.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

cortisiko

🌮 🌮 🌮

mathieuartu added 2 commits September 13, 2024 10:05

feat(NOTIFY-1096): add account syncing

631dbe9

fix: import path

04780e0

mathieuartu added the team-notifications Notifications team label Sep 13, 2024

metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Sep 13, 2024

mathieuartu added 5 commits September 13, 2024 11:58

fix: useEffect

771ad50

fix: temporarily remove keyring-controller patch

2f20cdb

fix: yarn.lock

249a1ba

fix: remove Gemfile.lock

6e2b5b5

fix: add @ts-expect-error for controller version mismatch

888f01d

fix: remove unused import

b9bb37a

mathieuartu added Run Smoke E2E Triggers smoke e2e on Bitrise and removed INVALID-PR-TEMPLATE PR's body doesn't match template labels Sep 13, 2024

metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Sep 13, 2024

feat: group profile-sync effects under a layout effect + AppState cha…

6c9b2ce

…nge event

mathieuartu added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 13, 2024

mathieuartu added 2 commits September 13, 2024 17:18

add layouteffect deps

80af81c

Merge branch 'main' into feat/add_account_syncing

ab17435

mathieuartu added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 13, 2024

mathieuartu added 2 commits September 16, 2024 16:32

Merge branch 'main' into feat/add_account_syncing

95563d9

chore: remove preview packages and use latest deps

c8e8e91

mathieuartu added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 31, 2024

mathieuartu requested a review from cortisiko October 31, 2024 19:11

fix: yarn.lock

89cc06b

mathieuartu added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 31, 2024

mathieuartu added 2 commits October 31, 2024 22:34

Merge branch 'main' into feat/add_account_syncing

f790e56

fix: yarn.lock

5035497

mathieuartu added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 31, 2024

mathieuartu added 2 commits October 31, 2024 23:05

Merge branch 'main' into feat/add_account_syncing

ac749df

fix: yarn.lock

d0ce191

mathieuartu added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 31, 2024

cortisiko approved these changes Oct 31, 2024

View reviewed changes

mathieuartu added this pull request to the merge queue Nov 1, 2024

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 1, 2024

mathieuartu added this pull request to the merge queue Nov 1, 2024

Merged via the queue into main with commit 0e7606f Nov 1, 2024
43 checks passed

mathieuartu deleted the feat/add_account_syncing branch November 1, 2024 08:15

github-actions bot locked and limited conversation to collaborators Nov 1, 2024

metamaskbot added the release-7.36.0 Issue or pull request that will be included in release 7.36.0 label Nov 1, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(NOTIFY-1096): add account syncing #11190

feat(NOTIFY-1096): add account syncing #11190

mathieuartu commented Sep 13, 2024 •

edited

Loading

github-actions bot commented Sep 13, 2024 •

edited

Loading

mathieuartu commented Sep 13, 2024

socket-security bot commented Sep 13, 2024 •

edited

Loading

codecov-commenter commented Sep 13, 2024 •

edited

Loading

github-actions bot commented Sep 13, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Sep 13, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Sep 13, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Oct 31, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Oct 31, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Oct 31, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Oct 31, 2024 •

edited by metamaskbot

Loading

sonarqubecloud bot commented Oct 31, 2024

cortisiko left a comment

feat(NOTIFY-1096): add account syncing #11190

feat(NOTIFY-1096): add account syncing #11190

Conversation

mathieuartu commented Sep 13, 2024 • edited Loading

Description

Related issues

Manual testing steps

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Sep 13, 2024 • edited Loading

mathieuartu commented Sep 13, 2024

socket-security bot commented Sep 13, 2024 • edited Loading

codecov-commenter commented Sep 13, 2024 • edited Loading

Codecov Report

github-actions bot commented Sep 13, 2024 • edited by metamaskbot Loading

Bitrise

github-actions bot commented Sep 13, 2024 • edited by metamaskbot Loading

Bitrise

github-actions bot commented Sep 13, 2024 • edited by metamaskbot Loading

Bitrise

github-actions bot commented Oct 31, 2024 • edited by metamaskbot Loading

Bitrise

github-actions bot commented Oct 31, 2024 • edited by metamaskbot Loading

Bitrise

github-actions bot commented Oct 31, 2024 • edited by metamaskbot Loading

Bitrise

github-actions bot commented Oct 31, 2024 • edited by metamaskbot Loading

Bitrise

sonarqubecloud bot commented Oct 31, 2024

Quality Gate passed

cortisiko left a comment

Choose a reason for hiding this comment

mathieuartu commented Sep 13, 2024 •

edited

Loading

github-actions bot commented Sep 13, 2024 •

edited

Loading

socket-security bot commented Sep 13, 2024 •

edited

Loading

codecov-commenter commented Sep 13, 2024 •

edited

Loading

github-actions bot commented Sep 13, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Sep 13, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Sep 13, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Oct 31, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Oct 31, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Oct 31, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Oct 31, 2024 •

edited by metamaskbot

Loading