ci: prevent detox E2E lock failure

[cortisiko]

Description

The purpose of this PR is to address the recent flakiness we noticed in CI as it relates to detox failing with this type of error:

/Users/vagrant/git/node_modules/proper-lockfile/lib/lockfile.js:181
        onCompromised: (err) => { throw err; },
                                  ^
Error: Unable to update lock within the stale threshold
    at /Users/vagrant/git/node_modules/proper-lockfile/lib/lockfile.js:109:21
    at newFs.<computed> [as utimes] (/Users/vagrant/git/node_modules/proper-lockfile/lib/adapter.js:20:13)
    at Timeout._onTimeout (/Users/vagrant/git/node_modules/proper-lockfile/lib/lockfile.js:100:20)
    at listOnTimeout (node:internal/timers:573:17)
    at process.processTimers (node:internal/timers:514:7) {
  code: 'ECOMPROMISED'
}

This issue is on Detox's side. To remedy the issue I did two main things:

1. I applied a patch to Detox's Node module to help reduce test failures caused by the above failure. I increased the lock timeout to 20 seconds.
2. Before each run, I reset the detox lock file: detox reset-lock-file.

After three runs on Bitrise

• https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/782c9740-e8f3-4e5f-a0ac-e0b553328e11
• https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/93cdcfd5-9c2b-4cfa-ad18-c06dd38a6ea8
• https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a52569c4-b3fc-4779-b568-3b7b192c18d1

, the pipeline seemed much more stable than the main branch, which failed on every run.

Related issues

Fixes:

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: dad1a5e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d656ca5a-d7b6-48d2-9a32-e085dc312210

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[Cal-L]

Lgtm