Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: display "Snaps (Beta)" decorator tag in accounts list #11185

Merged
merged 24 commits into from
Sep 26, 2024
Merged

feat: display "Snaps (Beta)" decorator tag in accounts list #11185

merged 24 commits into from
Sep 26, 2024

Conversation

k-g-j
Copy link
Contributor

@k-g-j k-g-j commented Sep 12, 2024 •
edited by gantunesr
Loading

Description

This PR adds a "Snaps (Beta)" decorator tag for Snap accounts in the mobile accounts list.
The changes include:

  • Modified the AccountSelectorList component to identify Snap accounts.
  • Added a new localization string for the "Snaps (Beta)" tag.
  • Updated the rendering logic to display the tag for Snap accounts.

Related issues

Fixes: https://github.com/MetaMask/accounts-planning/issues/150

Manual testing steps

  1. Go to the SSK and create an account
  2. Open the accounts list
  3. You should see the tag "Snaps (beta)" under the name "Snap Account x"
  4. Create more accounts on the SSK
  5. You should see the snaps tag under each snap account

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@k-g-j k-g-j changed the base branch from main to feat/eth-snap-keyring September 12, 2024 19:33
@k-g-j k-g-j changed the title feat: display snap accounts list feat: display "Snaps (Beta)" decorator tag in accounts list Sep 12, 2024
@owencraston owencraston force-pushed the feat/eth-snap-keyring branch 11 times, most recently from cae529b to 3e4ee3a Compare September 19, 2024 19:12
@owencraston owencraston force-pushed the feat/eth-snap-keyring branch 5 times, most recently from 6bcddfe to 8763e21 Compare September 20, 2024 18:30
Base automatically changed from feat/eth-snap-keyring to main September 20, 2024 19:43
@k-g-j k-g-j marked this pull request as ready for review September 23, 2024 16:24
@k-g-j k-g-j requested a review from a team as a code owner September 23, 2024 16:24
@k-g-j k-g-j added the Run Smoke E2E Triggers smoke e2e on Bitrise label Sep 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 23, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: d4b7997
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ef4c2338-f9a8-4a9f-81ec-5fd8164f1241

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

owencraston
owencraston reviewed Sep 23, 2024
View reviewed changes
Copy link
Contributor

@owencraston owencraston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really good so far. Just a few small change request to turn these into functions. After that I will approve.

app/components/UI/AccountSelectorList/AccountSelector.test.tsx Outdated Show resolved Hide resolved
@k-g-j k-g-j requested review from a team as code owners September 23, 2024 21:16
@k-g-j
Copy link
Contributor Author

k-g-j commented Sep 24, 2024

What is the limitation here to use a placeholder copy instead of the snap name in the label? Os is this just an iteration?

This is for the initial iteration, but we should display the snap name and not the generic tag. I have created a branch that is exploring how to do this here and the issue is documented here

@k-g-j k-g-j removed the Run Smoke E2E Triggers smoke e2e on Bitrise label Sep 25, 2024
@k-g-j k-g-j added the Run Smoke E2E Triggers smoke e2e on Bitrise label Sep 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 25, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 218afe4
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/bced8a0a-4e08-419f-ba5b-aee648c3663e

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Cal-L
Cal-L reviewed Sep 26, 2024
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment!

app/util/address/index.ts Outdated Show resolved Hide resolved
@k-g-j k-g-j removed the Run Smoke E2E Triggers smoke e2e on Bitrise label Sep 26, 2024
@k-g-j k-g-j added the Run Smoke E2E Triggers smoke e2e on Bitrise label Sep 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 26, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 71f23b6
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c69feb09-c7b2-4f84-9661-d9e5aa5b33cb

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@k-g-j k-g-j removed the Run Smoke E2E Triggers smoke e2e on Bitrise label Sep 26, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@k-g-j k-g-j added the Run Smoke E2E Triggers smoke e2e on Bitrise label Sep 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 26, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 6bf4f3c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4faa76ce-32fc-4ba7-b105-9ccd302c18e7

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@k-g-j k-g-j added this pull request to the merge queue Sep 26, 2024
Merged via the queue into main with commit e93ea40 Sep 26, 2024
37 of 39 checks passed
@k-g-j k-g-j deleted the feat/display-snap-accounts-list branch September 26, 2024 18:36
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2024
@metamaskbot metamaskbot added the release-7.33.0 Issue or pull request that will be included in release 7.33.0 label Sep 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@owencraston owencraston owencraston approved these changes

@gantunesr gantunesr gantunesr left review comments

@Cal-L Cal-L Cal-L left review comments

Assignees
No one assigned
Labels
area-UI release-7.33.0 Issue or pull request that will be included in release 7.33.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-accounts
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@k-g-j @owencraston @Cal-L @gantunesr @metamaskbot