Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: switch from bundled to url EE #11176

Merged
merged 3 commits into from
Sep 12, 2024

Conversation

Jonathansoufer
Copy link
Contributor

Description

This is a simple yet important change of how we use execution environment since the bundled approach doesn't work on Android.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Jonathansoufer Jonathansoufer self-assigned this Sep 12, 2024
@Jonathansoufer Jonathansoufer requested a review from a team as a code owner September 12, 2024 13:10
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the team-snaps-platform Snaps Platform team label Sep 12, 2024
@Jonathansoufer Jonathansoufer added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 12, 2024
Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>
@Jonathansoufer Jonathansoufer added No QA Needed Apply this label when your PR does not need any QA effort. No E2E Smoke Needed If the PR does not need E2E smoke test run labels Sep 12, 2024
Copy link

@Jonathansoufer Jonathansoufer merged commit f8d2df6 into main Sep 12, 2024
36 checks passed
@Jonathansoufer Jonathansoufer deleted the fix/use-snap-execution-environment-url branch September 12, 2024 14:49
@github-actions github-actions bot locked and limited conversation to collaborators Sep 12, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 12, 2024
@metamaskbot metamaskbot added the release-7.32.0 Issue or pull request that will be included in release 7.32.0 label Sep 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No E2E Smoke Needed If the PR does not need E2E smoke test run No QA Needed Apply this label when your PR does not need any QA effort. release-7.32.0 Issue or pull request that will be included in release 7.32.0 team-snaps-platform Snaps Platform team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants