Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): let adb server live between builds #11136

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

joaoloureirop
Copy link
Contributor

Description

Introduced on 8fd7eb2

It breaks wireless adb connection, adb logcat, and any process that attaches to the running adb-server

Running adb server should not influence the ability to build

Related issues

Fixes: #11135

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Introduced on 8fd7eb2
It breaks wireless adb connection, adb logcat, and any
process that attaches to the running adb-server

Running adb server should not influence the ability to build
@joaoloureirop joaoloureirop added No QA Needed Apply this label when your PR does not need any QA effort. team-mobile-platform labels Sep 10, 2024
@joaoloureirop joaoloureirop self-assigned this Sep 10, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@joaoloureirop joaoloureirop marked this pull request as ready for review September 10, 2024 12:04
@joaoloureirop joaoloureirop requested a review from a team as a code owner September 10, 2024 12:04
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Sep 10, 2024
Copy link

@joaoloureirop joaoloureirop added this pull request to the merge queue Oct 8, 2024
Merged via the queue into main with commit 92154d3 Oct 8, 2024
50 checks passed
@joaoloureirop joaoloureirop deleted the chore/do-not-kill-adb-server branch October 8, 2024 14:58
@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template No QA Needed Apply this label when your PR does not need any QA effort. release-7.34.0 team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tooling: broken Android wireless debug
5 participants