Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update Appium documentation #11124

Merged
merged 6 commits into from
Sep 10, 2024
Merged

Conversation

cortisiko
Copy link
Member

Description

The goal of this task is to enhance the clarity of the Appium section, ensuring that everyone understands how tests are executed and triggered. The section needs refinement to provide clearer step-by-step instructions, so the process is easy to follow and all team members are aligned.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@cortisiko cortisiko added No QA Needed Apply this label when your PR does not need any QA effort. team-mobile-platform labels Sep 9, 2024
@cortisiko cortisiko self-assigned this Sep 9, 2024
@cortisiko cortisiko requested a review from a team as a code owner September 9, 2024 23:15
@cortisiko cortisiko linked an issue Sep 9, 2024 that may be closed by this pull request
9 tasks
Cal-L
Cal-L previously approved these changes Sep 9, 2024
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.91%. Comparing base (8dcdd3c) to head (7892d8f).
Report is 62 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11124      +/-   ##
==========================================
+ Coverage   52.75%   52.91%   +0.16%     
==========================================
  Files        1534     1545      +11     
  Lines       36777    36901     +124     
  Branches     4335     4352      +17     
==========================================
+ Hits        19403    19528     +125     
+ Misses      16058    16052       -6     
- Partials     1316     1321       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

SamuelSalas
SamuelSalas previously approved these changes Sep 10, 2024
This reverts commit 958abf4.
Copy link
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@cortisiko cortisiko merged commit de47a6c into main Sep 10, 2024
36 checks passed
@cortisiko cortisiko deleted the docs-update-appium-section-in-readme branch September 10, 2024 19:49
@github-actions github-actions bot locked and limited conversation to collaborators Sep 10, 2024
@metamaskbot metamaskbot added the release-7.32.0 Issue or pull request that will be included in release 7.32.0 label Sep 10, 2024
@NicolasMassart
Copy link
Contributor

NicolasMassart commented Sep 10, 2024

A bit late to comment as it's merged already, but I wanted to say it's nice work!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.32.0 Issue or pull request that will be included in release 7.32.0 team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Docs: Update Appium section in readme
7 participants