Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add new job to verify "All jobs pass" job for required PR check #11121

Merged
merged 17 commits into from
Sep 10, 2024

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented Sep 9, 2024

Description

This PR adds a new job called check-all-jobs-pass, which verifies all-jobs-pass step in Github CI. This new job will be used as the required check in branch protection rules for main and will only have 2 possible outcomes, fail or success. This ensures that the rule that blocks/allows PR merge will be respected at all times.

Related issues

Fixes:

Manual testing steps

  • Verify that PR is unblocked when all jobs in ci.yml passes (PR unblocked)
  • Verify that PR is blocked when any jobs fail in ci.yml (PR blocked)
  • Verify that PR is unblocked when a job is skipped in ci.yml (PR unblocked)

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Cal-L Cal-L requested a review from a team as a code owner September 9, 2024 19:00
Copy link
Contributor

github-actions bot commented Sep 9, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Cal-L Cal-L added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) No QA Needed Apply this label when your PR does not need any QA effort. labels Sep 9, 2024
Daniel-Cross
Daniel-Cross previously approved these changes Sep 9, 2024
Copy link
Contributor

@Daniel-Cross Daniel-Cross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, good catch

@Cal-L Cal-L changed the title fix: Always run all-jobs-pass for github CI fix: Remove all jobs pass job from github CI Sep 9, 2024
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cal-L Cal-L changed the title fix: Remove all jobs pass job from github CI fix: Add new job to verify "All jobs pass" job for required PR check Sep 10, 2024
Copy link

@Cal-L Cal-L merged commit 72576bb into main Sep 10, 2024
40 checks passed
@Cal-L Cal-L deleted the ci/always-run-all-jobs-pass branch September 10, 2024 00:11
@github-actions github-actions bot locked and limited conversation to collaborators Sep 10, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 10, 2024
@metamaskbot metamaskbot added the release-7.32.0 Issue or pull request that will be included in release 7.32.0 label Sep 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.32.0 Issue or pull request that will be included in release 7.32.0 team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants