-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add new job to verify "All jobs pass" job for required PR check #11121
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, good catch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Quality Gate passedIssues Measures |
Description
This PR adds a new job called
check-all-jobs-pass
, which verifiesall-jobs-pass
step in Github CI. This new job will be used as the required check in branch protection rules formain
and will only have 2 possible outcomes, fail or success. This ensures that the rule that blocks/allows PR merge will be respected at all times.Related issues
Fixes:
Manual testing steps
ci.yml
passes (PR unblocked)ci.yml
(PR blocked)ci.yml
(PR unblocked)Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist