Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): Bump @metamask/phishing-controller from ^9.0.0 to ^12.0.1 #11111

Merged
merged 29 commits into from
Sep 27, 2024
Merged

chore(deps): Bump @metamask/phishing-controller from ^9.0.0 to ^12.0.1 #11111

merged 29 commits into from
Sep 27, 2024

Conversation

MajorLift
Copy link
Contributor

@MajorLift MajorLift commented Sep 9, 2024 •
edited
Loading

Description

### Changed

- **BREAKING:** Bump `@metamask/phishing-controller` from `^9.0.0` to `^12.0.1` ([#11111](https://github.com/MetaMask/metamask-mobile/pull/11111))

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@MajorLift MajorLift self-assigned this Sep 9, 2024
@MajorLift MajorLift changed the base branch from main to jongsun/fix-composable-controller September 9, 2024 14:28
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 9, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@MajorLift MajorLift added the DO-NOT-MERGE Pull requests that should not be merged label Sep 9, 2024
@socket-security Socket Security
Copy link

socket-security bot commented Sep 9, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/phishing-controller@12.0.3 network 0 305 kB danfinlay, gudahtt, kumavis, ...8 more

🚮 Removed packages: npm/@metamask/phishing-controller@9.0.2

View full report↗︎

@MajorLift MajorLift force-pushed the jongsun/fix-composable-controller branch from 56bbd96 to 49b971f Compare September 9, 2024 16:18
MajorLift added a commit that referenced this pull request Sep 9, 2024
@MajorLift
Restore @ts-expect-error directive for PhishingControllerMessenger
47d002b 
- To be removed here #11111
@MajorLift MajorLift force-pushed the jongsun/chore/bump/phishing-controller-12.0.1 branch 3 times, most recently from 3809adb to 7fae89f Compare September 9, 2024 17:10
@MajorLift MajorLift force-pushed the jongsun/fix-composable-controller branch from bb07086 to 172b0a0 Compare September 9, 2024 17:19
@MajorLift MajorLift force-pushed the jongsun/chore/bump/phishing-controller-12.0.1 branch from 7fae89f to f9fd98b Compare September 9, 2024 17:20
MajorLift added a commit that referenced this pull request Sep 9, 2024
@MajorLift
Restore @ts-expect-error directive for PhishingControllerMessenger
5ec5ea7 
- To be removed here #11111
@MajorLift MajorLift force-pushed the jongsun/fix-composable-controller branch from 172b0a0 to cef95c9 Compare September 9, 2024 17:28
@MajorLift MajorLift force-pushed the jongsun/chore/bump/phishing-controller-12.0.1 branch from f9fd98b to 1f7fbe5 Compare September 9, 2024 17:32
MajorLift added a commit that referenced this pull request Sep 9, 2024
@MajorLift
Restore @ts-expect-error directive for PhishingControllerMessenger
af3dbea 
- To be removed here #11111
@MajorLift MajorLift force-pushed the jongsun/fix-composable-controller branch from cef95c9 to 6e69e1c Compare September 9, 2024 17:35
@MajorLift MajorLift force-pushed the jongsun/chore/bump/phishing-controller-12.0.1 branch from 1f7fbe5 to 45bc8a3 Compare September 9, 2024 17:44
@MajorLift MajorLift marked this pull request as ready for review September 9, 2024 17:58
@MajorLift MajorLift requested review from a team as code owners September 9, 2024 17:58
@MajorLift MajorLift requested a review from a team September 9, 2024 18:04
MajorLift added a commit that referenced this pull request Sep 10, 2024
@MajorLift
Restore @ts-expect-error directive for PhishingControllerMessenger
5be68fd 
- To be removed here #11111
@MajorLift MajorLift force-pushed the jongsun/fix-composable-controller branch from 470a124 to a332749 Compare September 10, 2024 07:58
@MajorLift MajorLift force-pushed the jongsun/chore/bump/phishing-controller-12.0.1 branch from 45bc8a3 to 87b1ce5 Compare September 10, 2024 08:04
mikesposito
mikesposito reviewed Sep 10, 2024
View reviewed changes
yarn.lock Outdated Show resolved Hide resolved
mikesposito
mikesposito reviewed Sep 10, 2024
View reviewed changes
yarn.lock Outdated Show resolved Hide resolved
cryptodev-2s
cryptodev-2s previously approved these changes Sep 10, 2024
View reviewed changes
@mikesposito mikesposito added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 23, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 05f5149
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/545c2270-7972-444d-9702-cc1ce7f67580

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@mikesposito
Copy link
Member

mikesposito commented Sep 23, 2024 •
edited
Loading

Failed conditions
25.9% Coverage on New Code (required ≥ 40%)

I'm a bit confused by the lines shown as "added" in Sonar, but some methods that were originally uncovered have been renamed.

@mikesposito mikesposito added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 23, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 4eed0b2
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/76fc4614-91e7-4774-b912-fac2fe29006d

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@Cal-L Cal-L added the skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. label Sep 27, 2024
Cal-L
Cal-L approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cryptodev-2s cryptodev-2s added this pull request to the merge queue Sep 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 27, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
25.9% Coverage on New Code (required ≥ 40%)

See analysis details on SonarCloud

@Cal-L Cal-L added this pull request to the merge queue Sep 27, 2024
Merged via the queue into main with commit e5de779 Sep 27, 2024
35 of 36 checks passed
@Cal-L Cal-L deleted the jongsun/chore/bump/phishing-controller-12.0.1 branch September 27, 2024 21:40
@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2024
@gauthierpetetin gauthierpetetin added the release-7.33.0 Issue or pull request that will be included in release 7.33.0 label Oct 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mikesposito mikesposito mikesposito left review comments

@Cal-L Cal-L Cal-L approved these changes

@cryptodev-2s cryptodev-2s cryptodev-2s approved these changes

Assignees

@mikesposito mikesposito

Labels
release-7.33.0 Issue or pull request that will be included in release 7.33.0 Run Smoke E2E Triggers smoke e2e on Bitrise skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. team-wallet-framework
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PhishingController upgrade from v9 to v12
7 participants
@MajorLift @codecov-commenter @mikesposito @Cal-L @cryptodev-2s @gauthierpetetin @tommasini